Prototype for adding RangeSlider support for macOS #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slider is amazing! It also has such potential for working on macOS; thought I'd try to get it to work using the Cocoa framework. I'm not experienced with macOS so some things are very hard for me to figure out right now. This works decently if you set a static frame (however, the knobs are clipped to the rectangle that encapsulates NSControl, something that doesn't happen with iOS). It does not seem to behave at all when using auto-layout constraints too (it doesn't appear at all).
I'm hoping this PR will at least get the ball rolling for working on macOS (and perhaps some might know how to immediately address the issues I am encountering right now).