[pull] master from ElunaLuaEngine:master #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Each core now has its own method directory, this makes it a lot easier and cleaner to both maintain and add new methods When adding new methods, they should be defined in both the LuaFunctions.cpp and the respective Method.h file. Please also add the registry entry to the other cores' method registry, so we know what's implemented or not. When a method is not implemented, it should point to a nullptr in the registry.
Fix CMaNGOS specific functions per expansion
CMaNGOS specific fixes
Also fixes issues where some methods were not registered like they should
-Remove all other core defines in headers -Add CMaNGOS Cata compatibility
-Fix incorrect MaNGOS option for enable/disable of Eluna -Update checkout actions to newer version since old version has deprecated functions -Add CMaNGOS Cata fork to CI checks -Upgrade CMaNGOS build environment to Ubuntu 22.04
CMaNGOS specific cleanups and CI update
Cata Preservation Project Changes
Add Cata Preservation Project support
-Add Cata Preservation Project(TC based) to CI check
Update CI build file
-Will need additional method header cleanup and adjustments
These are somewhat equivalent with the AzerothCore custom hooks, though they do work a little differently. Ensure to read the documentation if something differs.
Co-Authored-By: Foereaper <[email protected]>
This should fix having to cast the return value manually in scripts
Only the ones compatible with CMangos have been added Co-Authored-By: Foereaper <[email protected]>
Modified from PR#314 since core hook catches all skills not just crafting Co-Authored-By: CyberMist <[email protected]>
-As Foe found when converting to this system placing a function with a nullptr causes all the functions below it to not register properly and not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )