Skip visiting any tags inside of NOSCRIPT elements

[westonruter]

Any tag which appears in a NOSCRIPT should always be excluded from visiting by any tag visitor. For example:

<noscript>
	<img decoding="async" src="https://example.com/pixel.gif" alt="" width="1" height="1">
</noscript>

Currently this shows up on pages as:

<noscript>
	<img data-od-unknown-tag src="https://example.com/pixel.gif" alt="" width="1" height="1">
</noscript>

Image Prioritizer adds the data-od-unknown-tag attribute to any visited tag IMG which is not located in URL Metrics. However, such an IMG can never be added to URL Metrics since it is not located in the DOM.

This PR skips over visiting any tag which is inside of a NOSCRIPT element.

Such NOSCRIPT tags are often found with JS-based lazy-loading implementations.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.43%. Comparing base (4693bee) to head (14f57a8).
Report is 3 commits behind head on trunk.

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk    #1783      +/-   ##
==========================================
+ Coverage   57.42%   57.43%   +0.01%     
==========================================
  Files          84       84              
  Lines        6506     6508       +2     
==========================================
+ Hits         3736     3738       +2     
  Misses       2770     2770              

Flag	Coverage Δ
multisite	57.43% <100.00%> (+0.01%)	⬆️
single	34.46% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[felixarntz]

@westonruter Great catch!