Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site Health test to verify that static assets are served with far-future expires #1727

Merged
merged 34 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
dc9e364
Add site health checks for far-future expiration headers
b1ink0 Dec 9, 2024
4cb07aa
Add filter for customizing far-future headers threshold
b1ink0 Dec 9, 2024
ec9a552
Refactor far-future headers checks and improve asset validation logic
b1ink0 Dec 9, 2024
dd8e70d
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Dec 9, 2024
0078cfc
Use assets from wp-includes for far-future headers site health check
b1ink0 Dec 10, 2024
3e5d958
Add filter to customize assets checked for far-future headers
b1ink0 Dec 10, 2024
35e7977
Enhance far-future headers check to return detailed results and gener…
b1ink0 Dec 10, 2024
3db5886
Improve far-future headers checks by adding detailed failure reasons …
b1ink0 Dec 10, 2024
655d4e5
Add test to ensure status is 'good' when all headers are valid
b1ink0 Dec 11, 2024
20099bf
Add test for assets with conditional caching
b1ink0 Dec 12, 2024
54f3621
Add test for status messages based on far-future headers results
b1ink0 Dec 12, 2024
0a776c5
Add tests for filters affecting far-future headers asset checks
b1ink0 Dec 12, 2024
3c98337
Refactor to use filenames instead of extenstions in failure details
b1ink0 Dec 12, 2024
7afd746
Filter assets to ensure only string URLs are checked
b1ink0 Jan 8, 2025
3fcd641
Update parameter type hints for far-future headers functions
b1ink0 Jan 8, 2025
54c73ec
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Jan 8, 2025
6a2da47
Include max-age, expires actual value and threshold value in error me…
b1ink0 Jan 9, 2025
48166ac
Simplify filename extraction and conditional logic
b1ink0 Jan 9, 2025
17d380e
Refactor header checks to use null coalescing and improve conditionals
b1ink0 Jan 9, 2025
200b518
Fix far future headers tests failing due to updated error messages
b1ink0 Jan 9, 2025
1b4cef4
Improve error messages for far future headers check
b1ink0 Jan 10, 2025
ed28196
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Jan 10, 2025
ee3a57d
Update labels to make them less technical
b1ink0 Jan 15, 2025
f6ba392
Add cover annotations for tests and test for when no assets are passed
b1ink0 Jan 15, 2025
0620840
Mark functions as private
b1ink0 Jan 15, 2025
7ebdc87
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Jan 16, 2025
49ca83f
Add covers tags
westonruter Jan 17, 2025
12d0b71
Refactor to only return array to improve clarity, Simplify conditiona…
b1ink0 Jan 20, 2025
aec6f80
Add additional tests to improve code coverage
b1ink0 Jan 20, 2025
2190d60
Rename directories and files from 'far-furure-headers' to 'effective-…
b1ink0 Jan 22, 2025
4f1a00d
Rename functions and update comments to reflect effective caching hea…
b1ink0 Jan 22, 2025
2d08732
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Jan 22, 2025
a048e9f
Update comments to reflect effective asset cache headers in site heal…
b1ink0 Jan 22, 2025
2c70bd0
Update comment
westonruter Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,331 @@
<?php
/**
* Helper function to detect if static assets have effective caching headers.
*
* @package performance-lab
* @since n.e.x.t
*/

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
// @codeCoverageIgnoreEnd

/**
* Callback for the effective caching headers test.
*
* @since n.e.x.t
* @access private
*
* @return array{label: string, status: string, badge: array{label: string, color: string}, description: string, actions: string, test: string} Result.
*/
function perflab_effective_asset_cache_headers_assets_test(): array {
$result = array(
'label' => __( 'Your site serves static assets with an effective caching strategy', 'performance-lab' ),
'status' => 'good',
'badge' => array(
'label' => __( 'Performance', 'performance-lab' ),
'color' => 'blue',
),
'description' => sprintf(
'<p>%s</p>',
esc_html__(
'Serving static assets with far-future expiration headers improves performance by allowing browsers to cache files for a long time, reducing repeated requests.',
'performance-lab'
)
),
'actions' => '',
'test' => 'is_effective_asset_cache_headers_enabled',
);

// List of assets to check.
$assets = array(
includes_url( 'js/wp-embed.min.js' ),
includes_url( 'css/buttons.min.css' ),
includes_url( 'fonts/dashicons.woff2' ),
includes_url( 'images/media/video.png' ),
);

/**
* Filters the list of assets to check for effective caching headers.
*
* @since n.e.x.t
*
* @param string[] $assets List of asset URLs to check.
*/
$assets = apply_filters( 'perflab_effective_asset_cache_headers_assets_to_check', $assets );
$assets = array_filter( (array) $assets, 'is_string' );

// Check if effective caching headers are enabled for all assets.
$results = perflab_effective_asset_cache_headers_check_assets( $assets );

if ( 'good' !== $results['final_status'] ) {
$result['status'] = $results['final_status'];
$result['label'] = __( 'Your site does not serve static assets with an effective caching strategy', 'performance-lab' );

if ( count( $results['details'] ) > 0 ) {
$result['actions'] = sprintf(
'<p>%s</p>%s<p>%s</p>',
esc_html__( 'The following file types do not have the recommended effective Cache-Control or Expires headers. Consider adding or adjusting Cache-Control or Expires headers for these asset types.', 'performance-lab' ),
perflab_effective_asset_cache_headers_get_status_table( $results['details'] ),
esc_html__( 'Note: "Conditionally cached" means that the browser can re-validate the resource using ETag or Last-Modified headers. This results in fewer full downloads but still requires the browser to make requests, unlike far-future expiration headers that allow the browser to fully rely on its local cache for a longer duration.', 'performance-lab' )
);
}
$result['actions'] .= sprintf(
'<p>%s</p>',
esc_html__( 'Effective Cache-Control or Expires headers can be added or adjusted with a small configuration change by your hosting provider.', 'performance-lab' )
);
}

return $result;
}

/**
* Checks if effective caching headers are enabled for a list of assets.
*
* @since n.e.x.t
* @access private
*
* @param string[] $assets List of asset URLs to check.
* @return array{final_status: string, details: array{filename: string, reason: string}[]} Final status and details.
*/
function perflab_effective_asset_cache_headers_check_assets( array $assets ): array {
$final_status = 'good';
$fail_details = array(); // Array of arrays with 'filename' and 'reason'.

foreach ( $assets as $asset ) {
$response = wp_remote_get( $asset, array( 'sslverify' => false ) );

// Extract filename from the URL.
$path_info = pathinfo( (string) wp_parse_url( $asset, PHP_URL_PATH ) );
$filename = $path_info['basename'] ?? basename( $asset );

if ( is_wp_error( $response ) ) {
// Can't determine headers if request failed, consider it a fail.
$final_status = 'recommended';
$fail_details[] = array(
'filename' => $filename,
'reason' => __( 'Could not retrieve headers', 'performance-lab' ),
);
continue;
}

$headers = wp_remote_retrieve_headers( $response );
if ( ! is_object( $headers ) && 0 === count( $headers ) ) {
// No valid headers retrieved.
$final_status = 'recommended';
$fail_details[] = array(
'filename' => $filename,
'reason' => __( 'No valid headers retrieved', 'performance-lab' ),
);
continue;
}

$check = perflab_effective_asset_cache_headers_check_headers( $headers );
if ( $check['passed'] ) {
// This asset passed effective caching headers test, no action needed.
continue;
}

// If not passed, decide whether to try conditional request.
if ( $check['missing_max_age'] ) {
// Only if no effective caching headers at all, we try conditional request.
$conditional_pass = perflab_effective_asset_cache_headers_try_conditional_request( $asset, $headers );
$final_status = 'recommended';
if ( ! $conditional_pass ) {
$fail_details[] = array(
'filename' => $filename,
'reason' => __( 'No effective caching headers and no conditional caching', 'performance-lab' ),
);
} else {
$fail_details[] = array(
'filename' => $filename,
'reason' => __( 'No effective caching headers but conditionally cached', 'performance-lab' ),
);
}
} else {
// If there's a max-age or expires but below threshold, we skip conditional.
$final_status = 'recommended';
$fail_details[] = array(
'filename' => $filename,
'reason' => $check['reason'],
);
}
}

return array(
'final_status' => $final_status,
'details' => $fail_details,
);
}

/**
* Checks if effective caching headers are enabled.
*
* @since n.e.x.t
* @access private
*
* @param WpOrg\Requests\Utility\CaseInsensitiveDictionary|array<string, string|array<string>> $headers Response headers.
* @return array{passed: bool, reason: string, missing_max_age: bool} Detailed result of the check.
*/
function perflab_effective_asset_cache_headers_check_headers( $headers ): array {
/**
* Filters the threshold for effective caching headers.
*
* @since n.e.x.t
*
* @param int $threshold Threshold in seconds.
*/
$threshold = apply_filters( 'perflab_effective_asset_cache_headers_expiration_threshold', YEAR_IN_SECONDS );

$cache_control = $headers['cache-control'] ?? '';
$expires = $headers['expires'] ?? '';

// Check Cache-Control header for max-age.
$max_age = 0;
if ( '' !== $cache_control ) {
// There can be multiple cache-control headers, we only care about max-age.
foreach ( (array) $cache_control as $control ) {
if ( 1 === preg_match( '/max-age\s*=\s*(\d+)/', $control, $matches ) ) {
$max_age = (int) $matches[1];
break;
}
}
}

// If max-age meets or exceeds the threshold, we consider it good.
if ( $max_age >= $threshold ) {
return array(
'passed' => true,
'reason' => '',
'missing_max_age' => false,
);
}

// If max-age is too low or not present, check Expires.
if ( is_string( $expires ) && '' !== $expires ) {
$expires_time = strtotime( $expires );
$remaining_time = is_int( $expires_time ) ? $expires_time - time() : 0;
if ( $remaining_time >= $threshold ) {
// Good - Expires far in the future.
return array(
'passed' => true,
'reason' => '',
'missing_max_age' => false,
);
}

// Expires header exists but not far enough in the future.
if ( $max_age > 0 ) {
return array(
'passed' => false,
'reason' => sprintf(
/* translators: 1: actual max-age value in seconds, 2: threshold in seconds */
__( 'max-age below threshold (actual: %1$s seconds, threshold: %2$s seconds)', 'performance-lab' ),
number_format_i18n( $max_age ),
number_format_i18n( $threshold )
),
'missing_max_age' => false,
);
}
return array(
'passed' => false,
'reason' => sprintf(
/* translators: 1: actual Expires header value in seconds, 2: threshold in seconds */
__( 'expires below threshold (actual: %1$s seconds, threshold: %2$s seconds)', 'performance-lab' ),
number_format_i18n( $remaining_time ),
number_format_i18n( $threshold )
),
'missing_max_age' => false,
);
}

// No max-age or expires found at all or max-age < threshold and no expires.
if ( 0 === $max_age ) {
return array(
'passed' => false,
'reason' => '',
'missing_max_age' => true,
);
} else {
// max-age was present but below threshold and no expires.
return array(
'passed' => false,
'reason' => sprintf(
/* translators: 1: actual max-age value in seconds, 2: threshold in seconds */
__( 'max-age below threshold (actual: %1$s seconds, threshold: %2$s seconds)', 'performance-lab' ),
number_format_i18n( $max_age ),
number_format_i18n( $threshold )
),
'missing_max_age' => false,
);
}
}

/**
* Attempt a conditional request with ETag/Last-Modified.
*
* @since n.e.x.t
* @access private
*
* @param string $url The asset URL.
* @param WpOrg\Requests\Utility\CaseInsensitiveDictionary|array<string, string|array<string>> $headers The initial response headers.
* @return bool True if a 304 response was received.
*/
function perflab_effective_asset_cache_headers_try_conditional_request( string $url, $headers ): bool {
$etag = $headers['etag'] ?? '';
$last_modified = $headers['last-modified'] ?? '';

$conditional_headers = array();
if ( '' !== $etag ) {
$conditional_headers['If-None-Match'] = $etag;
}
if ( '' !== $last_modified ) {
$conditional_headers['If-Modified-Since'] = $last_modified;
}

$response = wp_remote_get(
$url,
array(
'sslverify' => false,
'headers' => $conditional_headers,
)
);

if ( is_wp_error( $response ) ) {
return false;
}

$status_code = wp_remote_retrieve_response_code( $response );
return ( 304 === $status_code );
}

/**
* Generate a table listing files that need effective caching headers, including reasons.
*
* @since n.e.x.t
* @access private
*
* @param array<array{filename: string, reason: string}> $fail_details Array of arrays with 'filename' and 'reason'.
* @return string HTML formatted table.
*/
function perflab_effective_asset_cache_headers_get_status_table( array $fail_details ): string {
$html_table = sprintf(
'<table class="widefat striped"><thead><tr><th scope="col">%s</th><th scope="col">%s</th></tr></thead><tbody>',
esc_html__( 'File', 'performance-lab' ),
esc_html__( 'Status', 'performance-lab' )
);

foreach ( $fail_details as $detail ) {
$html_table .= sprintf(
'<tr><td>%s</td><td>%s</td></tr>',
esc_html( $detail['filename'] ),
esc_html( $detail['reason'] )
);
}

$html_table .= '</tbody></table>';

return $html_table;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php
/**
* Hook callbacks used for effective caching headers.
*
* @package performance-lab
* @since n.e.x.t
*/

// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
// @codeCoverageIgnoreEnd

/**
* Adds tests to site health.
*
* @since n.e.x.t
* @access private
*
* @param array{direct: array<string, array{label: string, test: string}>} $tests Site Health Tests.
* @return array{direct: array<string, array{label: string, test: string}>} Amended tests.
*/
function perflab_effective_asset_cache_headers_add_test( array $tests ): array {
$tests['direct']['effective_asset_cache_headers'] = array(
'label' => __( 'Effective Caching Headers', 'performance-lab' ),
'test' => 'perflab_effective_asset_cache_headers_assets_test',
);
return $tests;
}
add_filter( 'site_status_tests', 'perflab_effective_asset_cache_headers_add_test' );

Check warning on line 31 in plugins/performance-lab/includes/site-health/effective-asset-cache-headers/hooks.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/effective-asset-cache-headers/hooks.php#L31

Added line #L31 was not covered by tests
4 changes: 4 additions & 0 deletions plugins/performance-lab/includes/site-health/load.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,7 @@
// AVIF headers site health check.
require_once __DIR__ . '/avif-headers/helper.php';
require_once __DIR__ . '/avif-headers/hooks.php';

// Effective Asset Cache Headers site health check.
require_once __DIR__ . '/effective-asset-cache-headers/helper.php';
require_once __DIR__ . '/effective-asset-cache-headers/hooks.php';

Check warning on line 37 in plugins/performance-lab/includes/site-health/load.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/load.php#L36-L37

Added lines #L36 - L37 were not covered by tests
Loading
Loading