Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fixed method usage because of method signature change in docker-compose 0.24.6 #59184

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Bug: Fixed method usage because of method signature change in docker-compose 0.24.6 #59184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5593c63
changed down() to downAll() for docker-compose 0.24.4
Feb 19, 2024
8220154
adapt package-lock.json to 0.24.4
angcl Feb 19, 2024
e8234d5
fix package-lock.json issue and bump to 0.24.5
angcl Feb 19, 2024
e6050dd
add changelog entry
angcl Feb 19, 2024
a0d89fb
increase docker-compose version to 0.24.6
Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions packages/env/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fix

- Update `docker-compose` dependency to `0.24.6` and change method calls from `down()` to the new `downAll()`.

## 9.3.0 (2024-02-09)

## 9.2.0 (2024-01-24)
Expand Down
2 changes: 1 addition & 1 deletion packages/env/lib/commands/destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module.exports = async function destroy( { spinner, scripts, debug } ) {

spinner.text = 'Removing docker images, volumes, and networks.';

await dockerCompose.down( {
await dockerCompose.downAll( {
config: config.dockerComposeConfigPath,
commandOptions: [ '--volumes', '--remove-orphans', '--rmi', 'all' ],
log: debug,
Expand Down
2 changes: 1 addition & 1 deletion packages/env/lib/commands/stop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = async function stop( { spinner, debug } ) {

spinner.text = 'Stopping WordPress.';

await dockerCompose.down( {
await dockerCompose.downAll( {
config: dockerComposeConfigPath,
log: debug,
} );
Expand Down
2 changes: 1 addition & 1 deletion packages/env/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"dependencies": {
"chalk": "^4.0.0",
"copy-dir": "^1.3.0",
"docker-compose": "^0.24.3",
"docker-compose": "^0.24.6",
"extract-zip": "^1.6.7",
"got": "^11.8.5",
"inquirer": "^7.1.0",
Expand Down
Loading