-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Do not display progress bar when Image is uploading in the Editor #58657
Conversation
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
RFC: I have considered if My reasoning was that the IMO, it is more straightforward to pass gutenberg/packages/block-editor/src/components/media-upload-progress/index.native.js Lines 192 to 202 in b69c18d
|
Closing in favor of the approach in #58759. |
Fixes:
What?
This PR mobile editor media uploads to not display a spinner or opacity change when the media type is an Image.
Why?
As part of ongoing efforts to improve the media upload experience, we have received feedback that Image upload process could be improved by not displaying an "in progress" state when uploading Images.
This PR focuses on UI display only, and intentionally does not update any of the media progress upload logic in order to reduce regressions.
How?
hideProgressBar
hideProgressBar={ true }
to the Image block to ensure the progress bar can be displayed for other components.Testing Instructions
Scenario 1: Testing Images
Scenario 1: Testing other media
Testing Instructions for Keyboard
Screenshots or screencast
Image.Uploads.No.Progress.mov
Todo