Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social: Improve block labels and descriptions for clarity #68858

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Social: Improve block labels and descriptions for clarity #68858

wants to merge 2 commits into from
+4 −2

Conversation

SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented Jan 23, 2025 •
edited
Loading

Closes: #68855

What?

This PR updates the labels in the Social Links block to clarify that the styling options apply to both icons and text when labels are enabled.

Why?

The previous labels ("Icon color" and "Icon background") did not accurately describe the scope of the styling when text labels were displayed alongside icons, leading to potential confusion for users.

How?

  • Updated the label for the icon color option to dynamically display "Icon & text color" when labels are enabled.
  • Updated the label for the icon background option to dynamically display "Icon & text background" when labels are enabled.

Testing Instructions

  1. Open the editor and insert the Social Links block.
  2. Toggle the "Show text" option in the block settings.
  3. Observe that:
    • When labels are disabled, the options read "Icon color" and "Icon background."
    • When labels are enabled, the options read "Icon & text color" and "Icon & text background."
  4. Verify that the functionality of color and background settings remains unchanged.

Screenshots

Before After
Screenshot 2025-01-24 at 12 54 03 PM Screenshot 2025-01-24 at 12 53 03 PM

@SainathPoojary SainathPoojary marked this pull request as ready for review January 24, 2025 07:44
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@SainathPoojary SainathPoojary mentioned this pull request Jan 24, 2025
Open
6 tasks
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Social Affects the Social Block - used to display Social Media accounts labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Social Icons block: setting labels always refer to 'icon' even when Show text is enabled
2 participants
@SainathPoojary @t-hamano