Social Icons block: setting labels always refer to 'icon' even when Show text is enabled

[afercia]

Description

By default, the links for the 'Social Icons` block only show the social media icon. In this case, the color setting labels for the colors:

• Icon color
• Icon background

make sense because the block shows only the icon. Screenshot:

However, the block does have a 'Show text' setting that, when enabled, will show the social media name via some visible text after the icon. In this case, the color setting labels aren't appropriate because, well, it's not just about the icon. The color settings will change the tex color as well while the UI is still telling users that those settings will change the icon color. Screenshot:

I'd argue that even the block name and description aren't entirely appropriate because 'Social Icons` isn't what this block is about.

At the very least, the labels for the color setting should either be more generic or change to some more appropriate wording when 'Show text' is enabled.

Step-by-step reproduction instructions

• Add a Social Icons block and add some links to some socials.
• Observe the color settings in the block settings panel > styles always refer to the 'icon' colors even when 'show text' is enabled.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[SainathPoojary]

Hey @afercia,

I have addressed the first point about the color settings text in #68858. For the second point, changing the label and description. I think it would cause confusion because the block name (core/social-links) and the block title (“Brand Icons”) would no longer match. Changing the name would require updates everywhere core/social-links is used, and it might also break third-party plugins and themes that rely on the current name.

That said, “Brand Icons” could be a better name since it includes both social icons and brand names. However, I think this should be handled as a separate issue to carefully review the impact of such a change.

cc: @Mamaduka @fabiankaegy

[afercia]

I agree the block name should be considered separately.
However, the block internal name core/social-link should stay unchanged. It's the visible labels and descriptions in the UI Social Icons that don't make much sense.