Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes null pointer exceptions #1179

Open
wants to merge 273 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
273 commits
Select commit Hold shift + click to select a range
40bc1d9
Updating ids
jeduan Jul 6, 2015
6f4a243
1.0.0-dev.1
jeduan Jul 6, 2015
4562492
1.0.0
jeduan Jul 6, 2015
af98215
Syncs versions in plugin.xml
jeduan Jul 6, 2015
a5f2775
Swizzles application: handleOpenUrl:
jeduan Jul 13, 2015
adb41d5
1.0.1
jeduan Jul 13, 2015
cae3098
Removing references to PG Build
jeduan Aug 2, 2015
679e640
Updates documentation for browser development
jeduan Aug 3, 2015
e9b7e47
Updating docs
jeduan Aug 3, 2015
a1d6e55
JavaScript refactoring
jeduan Aug 3, 2015
03a5abb
1.1.0
jeduan Aug 3, 2015
43501a3
1.1.1
jeduan Aug 3, 2015
35ee411
Upgrades SDK to v4.4
jeduan Aug 3, 2015
ce72f0e
Basic support for App Invites on iOS
jeduan Aug 3, 2015
6017022
Added a missing comma
Aug 7, 2015
fca891d
Implemented the android side of app invite
Aug 7, 2015
b4f4a31
Updated readme with app invite usage
Aug 7, 2015
6083f73
Merge pull request #13 from ArnaudValensi/feature/appinvites
jeduan Aug 7, 2015
e75c9c7
Fixes #7 where the app would crash if the user cancelled login
jeduan Aug 3, 2015
d1fbfd5
Updates README
jeduan Aug 10, 2015
99c216e
Merge pull request #15 from jeduan/feature/appinvites
jeduan Aug 10, 2015
e356171
1.2.0
jeduan Aug 10, 2015
27e4fc0
Include Bolts.framework for iOS
Aug 20, 2015
18605b4
Merge pull request #22 from hkaju/master
jeduan Aug 20, 2015
fd384d0
1.2.1
jeduan Aug 20, 2015
8391dcb
Change link to href in readme
cosmith Aug 21, 2015
a5966fd
Insert SDK after defining the fbAsyncInit callback
thomashilzendegen Aug 21, 2015
c3af000
Merge pull request #23 from cosmith/patch-1
jeduan Aug 24, 2015
3c5c8b8
Merge pull request #24 from thomashilzendegen/master
jeduan Aug 24, 2015
9530596
1.2.2
jeduan Aug 24, 2015
f201b08
Adding Facebook iOS version 4.5.1 #19
jeduan Aug 27, 2015
e6ed023
1.3.0
jeduan Aug 27, 2015
8a53f82
Updates frameworks
jeduan Aug 24, 2015
17018b7
Changes for iOS9
jeduan Sep 2, 2015
b872530
1.4.0-0
jeduan Sep 3, 2015
42b55a6
Logs app activation. Fixes #17
jeduan Sep 7, 2015
ee2e0ba
feed method is now an alias for share
jeduan Sep 7, 2015
acebb5a
Updating Bolts to v1.2.2. Fixes #33
jeduan Sep 10, 2015
70cb720
1.4.0-1
jeduan Sep 10, 2015
44cc354
Updating to Facebook SDK v4.6
jeduan Sep 15, 2015
2766796
1.4.0
jeduan Sep 15, 2015
f3f1b7f
https://github.com/jeduan/cordova-plugin-facebook4/issues/42
Sep 17, 2015
f3c24f3
Merge pull request #45 from gillesperrin/master
jeduan Sep 18, 2015
cd5a1ca
added better callbacks for appInvite on iOS
Oct 6, 2015
a0961bc
fixed callback error
Oct 6, 2015
17faf09
remove whitespace
Oct 6, 2015
4ccb121
Merge pull request #60 from nightstomp/master
jeduan Oct 6, 2015
663a487
Revert "added better callbacks for appInvite on iOS"
jeduan Oct 6, 2015
f68bcd5
Merge pull request #61 from jeduan/revert-60-master
jeduan Oct 6, 2015
5a93ead
Merge remote-tracking branch 'jeduan/master'
Oct 6, 2015
9dfc696
better appInvite callbacks
Oct 6, 2015
d95ff08
Stop crashes when handleError is called
Oct 15, 2015
7fcc2e4
Merge pull request #62 from nightstomp/master
jeduan Oct 28, 2015
bde2b1e
Merge pull request #67 from kriserickson/master
jeduan Oct 28, 2015
e249f64
fix java.lang.NullPointerException when graphPath is null
DrMoriarty Nov 12, 2015
ca5b18d
check response of graph call
DrMoriarty Nov 12, 2015
0c76850
iOS SDK v4.7
jeduan Nov 20, 2015
6393e4f
SPDX licence compatibility
jeduan Nov 20, 2015
d75e240
Now automatically updates the XCode deployment target to the minimum …
jeduan Nov 20, 2015
17cc653
Updates NSAppTransportSecurity
jeduan Nov 20, 2015
540d15c
Moves AppInviteDialogDelegate implementation
jeduan Nov 20, 2015
f4e9eb7
Remove deprecated API for showing dialogs
jeduan Nov 20, 2015
52dcc26
Small refactor on responseObject
jeduan Nov 20, 2015
8a2f869
loginManager is now a singleton
jeduan Nov 20, 2015
b6c6743
Set plugin's onload param to true to enable install attribution
yanca232 Nov 23, 2015
d38f9b5
fix NPE in onResume
DrMoriarty Nov 24, 2015
abb396e
fix NPE in onResume
DrMoriarty Nov 24, 2015
862750e
Merge pull request #90 from RazorGator/master
jeduan Nov 24, 2015
4af08c2
Revert "Now automatically updates the XCode deployment target to the …
jeduan Dec 14, 2015
d0ba677
fix problem with cached tokens
Dec 14, 2015
31c79af
Merge branch 'master' of https://github.com/Wizcorp/phonegap-facebook…
DrMoriarty Dec 14, 2015
88b0d69
android support v4 conflicted with push plugin so updated it to v13
DrMoriarty Dec 14, 2015
f89493e
completionHandler is optinal,just call it with nil
Dec 15, 2015
48ee56c
Merge pull request #98 from Hirbod/patch-1
jeduan Dec 15, 2015
171a09f
Fixes issue that prevents presenting the facebook window
NGumby Dec 15, 2015
66539ec
Merge pull request #1 from compusport/Fix-when-used-with-InAppBrowser
NGumby Dec 15, 2015
5e14f7c
Update README.md
yoav-zibin Dec 17, 2015
f295e35
Merge pull request #101 from yoav-zibin/master
jeduan Dec 17, 2015
c00e52b
return error description in json format
DrMoriarty Dec 18, 2015
0023f10
Fixed issues with AppInvite callbacks on Android
dtritus Nov 30, 2015
e03d0be
Pass AppInvite dialog result to success callback
dtritus Dec 18, 2015
554d740
Merge pull request #94 from dtritus/master
jeduan Dec 20, 2015
1ac14dd
1.5.0
jeduan Dec 21, 2015
d00cf44
set fb_app_id not translatable
DrMoriarty Jan 21, 2016
257eba8
Added ios and android method to manually activate app with facebook e…
pragunvohra Feb 1, 2016
3e87a23
Updated share_open_graph to use Open Graph objects along with propert…
dorulazar Feb 2, 2016
d7756e0
Merge pull request #122 from DoruLa/master
jeduan Feb 4, 2016
0affa66
Linting
jeduan Feb 5, 2016
a566ce2
Adding README for manual activation events
jeduan Feb 5, 2016
ae41152
Merge branch 'pr/121'
jeduan Feb 5, 2016
fefb75e
1.6.0
jeduan Feb 5, 2016
aa8709c
1.6.1
jeduan Feb 6, 2016
00d6250
Send App Request Does Not Return Results
mkorganashvili Feb 9, 2016
52db932
Set up activity result callback before call show
mkorganashvili Feb 11, 2016
64635bd
Fixes #139
jeduan Feb 15, 2016
ec087d2
v1.6.2
jeduan Feb 15, 2016
dda57f2
Merge pull request #130 from mkorganashvili/patch-1
jeduan Feb 15, 2016
acd7ba7
Merge pull request #134 from mkorganashvili/patch-2
jeduan Feb 15, 2016
687ceb6
1.6.3
jeduan Feb 15, 2016
6511eec
Update ConnectPlugin.java
jcvalerio Feb 16, 2016
af4b5bf
Merge remote-tracking branch 'refs/remotes/originmaster/master'
NGumby Feb 18, 2016
6ade7a0
Merge pull request #142 from jcvalerio/master
jeduan Feb 24, 2016
73ffc86
added support for getDeferredApplink
Mar 3, 2016
58582cf
Fixed issue that grantedPermissions inspection always does not exist
Mar 4, 2016
f483017
Set minSdkVersion preference
pbakondy Mar 11, 2016
e21a50e
1.6.4
jeduan Mar 14, 2016
d6e5b06
Merge pull request #159 from T2123893/master
jeduan Mar 14, 2016
c2ded58
1.6.5
jeduan Mar 14, 2016
21cb1e1
Update ios plugin implement FBSDKGameRequestDialogDelegate
taina0407 Mar 2, 2016
10977bf
Merge pull request #156 from taina0407/master
jeduan Mar 15, 2016
d86e93f
1.7.0
jeduan Mar 15, 2016
4c6d3ee
Merge pull request #99 from compusport/master
jeduan Mar 15, 2016
aff9a08
Set Facebook Android SDK version to 4.8.+
Mar 23, 2016
6911f2d
Merge pull request #171 from TheCopartnery/master
jeduan Mar 23, 2016
aa89180
Update package.json
divyekhanna Mar 24, 2016
6c88ac5
Update plugin.xml
divyekhanna Mar 24, 2016
a3d0efb
Fix app_users filter
Apr 1, 2016
cd3128c
change android support dependency
DrMoriarty Apr 4, 2016
374d26a
Merge pull request #161 from pbakondy/minSdkVersion
Apr 22, 2016
9d623a5
Merge pull request #185 from platogo/fix-app-users-filter
Apr 22, 2016
b3270c8
Merge pull request #174 from divyekhanna/master
Apr 22, 2016
36d4005
Update README.md
Apr 23, 2016
5f66097
fix #102
Apr 23, 2016
6094370
fix plugin initialization for ios
DrMoriarty Apr 26, 2016
0078d09
Add share_native and share_feedWeb as share parameters
grmmph Apr 28, 2016
31bf4e8
Fix indetation
grmmph Apr 28, 2016
4071e9a
Fix indetation
grmmph Apr 28, 2016
f05ce3f
added support for getDeferredApplink
Apr 29, 2016
180df7e
Fix feed empty content bug on android
nihsuy May 4, 2016
17994a3
Update README
grmmph May 4, 2016
a2f6008
Merge pull request #207 from grmmph/master
May 4, 2016
da42bd7
#223 fix for signing in as different user
May 22, 2016
01740f9
Add OpenURL handler for ios9
pragunvohra May 25, 2016
5834aeb
I think the annotation is just 0x0
pragunvohra May 25, 2016
e37bab1
Update README.md
robertarnesson Jun 13, 2016
5e0d4cf
iOS: Added support for share Open Graph dialog
Jun 13, 2016
61d454c
sdk upgrade to v4.11.0
May 1, 2016
895fffa
Merge pull request #211 from nihsuy/fix/android-feed-empty-content
robertarnesson Jun 13, 2016
c452da1
Upgrade SDKCore
GabrielCTroia Jun 21, 2016
963467e
Upgrade SDKLoginKit
GabrielCTroia Jun 21, 2016
d395d8f
Upgrade FBSDKShareKit & FBSDKMessengerShareKit
GabrielCTroia Jun 21, 2016
843eae8
Merge pull request #252 from jackpocket/ios_sdk_v4.11.13
robertarnesson Jul 11, 2016
0806ce1
Update plugin.xml
robertarnesson Jul 11, 2016
e557377
don't include facebook-native.js for browser platform
robertarnesson Jul 11, 2016
b3e7386
Merge pull request #241 from edskeizer/master
robertarnesson Jul 11, 2016
bbcab50
Merge remote-tracking branch 'upstream/master'
jkassis Jul 20, 2016
ca4505e
send deferred links back to app for handling
jkassis Jul 20, 2016
4763c7c
Fixed Warnings Due to Deprecated APIS
tushar-bidchat Jul 21, 2016
47f720c
android support for deferredAppLinks
jkassis Jul 21, 2016
454a6ec
Merge pull request #270 from tushar-bidchat/master
robertarnesson Jul 21, 2016
71b481b
Add clarifying note to docs about changing APP_ID
marfire Jul 28, 2016
ea53d63
Updating Android and iOS SDK.
Aug 3, 2016
725885a
Fixing broken link in README.md
dudeofawesome Aug 7, 2016
df61960
Fixing broken link in browser/README.md
dudeofawesome Aug 7, 2016
7746da1
Merge remote-tracking branch 'origin/patch-2' into patch-1
dudeofawesome Aug 7, 2016
3d85b66
Merge pull request #281 from marfire/master
Aug 8, 2016
ee8aab5
Merge pull request #291 from dudeofawesome/patch-1
Aug 8, 2016
f746eef
Merge remote-tracking branch 'refs/remotes/jeduan/master'
Aug 14, 2016
5e797ea
Added forgotten semicolon
Aug 14, 2016
c8e4a92
1.7.2
Aug 23, 2016
0a5ac31
fix NullPointerException
robertarnesson Aug 23, 2016
5e87082
Merge pull request #288 from TheBosZ/master
robertarnesson Aug 23, 2016
2505e00
Merge pull request #224 from hoffination/master
robertarnesson Aug 23, 2016
086b3e8
Merge pull request #226 from pragunvohra/newOpenURL
robertarnesson Aug 23, 2016
879a966
simplified browser setup
Aug 25, 2016
a97f0dd
file:// protocol fix
robertarnesson Aug 26, 2016
b2d4536
add fbauth scheme for ios
DrMoriarty Aug 29, 2016
9363c69
buffer calls until js sdk is ready
Aug 29, 2016
bf094a8
1.7.3
Sep 2, 2016
b8765f7
js sdk v2.7
robertarnesson Sep 8, 2016
06eaa93
Merge remote-tracking branch 'fb4/master'
DrMoriarty Sep 14, 2016
049230a
disable actionType checking for dialogs
DrMoriarty Sep 14, 2016
77ceb2e
ios sdk 4.15.1
Sep 19, 2016
9b0882d
ios sdk 4.15.1
Sep 19, 2016
d093478
1.7.4
Sep 22, 2016
4ac0e4e
Merge branch 'master' of github.com:jeduan/cordova-plugin-facebook4
FME-nstokoe Oct 4, 2016
20daf8e
Merge remote-tracking branch 'fb4/master'
Nov 8, 2016
2a5ae1e
update ios fb sdk
Nov 9, 2016
099c294
references to jeduan
FME-nstokoe Nov 11, 2016
2db5112
Merge pull request #362 from nstokoe/jeduan-mergeable
robertarnesson Nov 11, 2016
17b9b22
Merge remote-tracking branch 'fb4/master'
Nov 16, 2016
bc44f39
Avoid FB prompt if required permission declined
simokhalil Nov 23, 2016
ef5f509
Update facebook-native.js
antonfire Nov 28, 2016
e5544b5
Update FacebookConnectPlugin.h
antonfire Nov 28, 2016
27aef95
Update FacebookConnectPlugin.m
antonfire Nov 28, 2016
254fa25
Update README.md
antonfire Nov 28, 2016
d6558c3
Update README.md
antonfire Nov 28, 2016
c578962
Update facebook-browser.js
simllll Nov 30, 2016
30ab2a8
Update facebook-browser.js
simllll Nov 30, 2016
d54042b
fix __fbSdkReady calls
simllll Dec 1, 2016
f24e9d8
Merge pull request #384 from simllll/master
robertarnesson Dec 2, 2016
3c75c4b
Updated outdated link to repo/docs
jQrgen Dec 12, 2016
62a5d8f
upgrade to the last facebook sdk + a fix
oak-tree Dec 20, 2016
fdea701
Fix link from contributing to troubleshooting
jkervine Feb 6, 2017
f4e8631
Add fix documentation
jkervine Feb 6, 2017
defdef2
Proper linking
jkervine Feb 6, 2017
f27d522
Merge pull request #434 from jkervine/document_ios10_login_issue
jeduan Feb 8, 2017
bca6485
Merge pull request #398 from CNATURE/master
jeduan Feb 8, 2017
6ac3baf
Merge pull request #392 from jQrgen/patch-1
jeduan Feb 8, 2017
57a58e3
Merge pull request #375 from simokhalil/master
jeduan Feb 8, 2017
63aa299
Merge pull request #382 from antonfire/master
jeduan Feb 8, 2017
a88f4d1
1.8.0
jeduan Feb 8, 2017
d7deb65
Added hashtag support (#418)
mpk2 Feb 9, 2017
7c0cc6b
Update plugin version in plugin.xml to 1.8.0 (#485)
jacquesdev May 16, 2017
6f05f70
ios sdk 4.22.0 (#481)
Alexious-sh May 16, 2017
c7219bd
SDK 4.22.1
jeduan May 16, 2017
d67a0fc
1.9.0
jeduan May 16, 2017
e9932dc
Update plugin version in plugin.xml to 1.9.0 (#509)
jacquesdev Jun 4, 2017
b5eadd1
Update plugin.xml to 1.9.1
jeduan Jun 4, 2017
3770c9c
1.9.1
jeduan Jun 4, 2017
573fb99
Merge remote-tracking branch 'fb4/master'
DrMoriarty Jul 3, 2017
37400c8
update ios fb sdk 4.24.0
DrMoriarty Jul 3, 2017
83e8fff
comment out deprecated fields in v.2.9 fg api
DrMoriarty Jul 18, 2017
22e7078
add fbapi20150629 into available url schemes
DrMoriarty Jul 20, 2017
5463d07
application:openURL needs to return BOOL value (#548)
vojtakopal Aug 25, 2017
6a8e6c9
Updated logPurchase to handle decimal values correctly. (#500)
Aug 25, 2017
3a3392c
Updated the ConnectPlugin so that it accepts multiple async requests …
RobertYoung Aug 25, 2017
0f2b695
Fix for facebook-browser.js (#561)
darkovac Sep 19, 2017
b99e247
Update Facebook SDK 4.31.1 for iOS 11 (#634)
peterpeterparker Mar 23, 2018
3be0474
Initial import
peterpeterparker Mar 24, 2018
a2c74db
Add notice for cordova-android >= 7 compatibility
peterpeterparker Apr 14, 2018
53e69ae
Spelling
peterpeterparker Apr 14, 2018
e6a9a43
Update for next version v1.10.0
peterpeterparker Apr 14, 2018
6f29de8
Add example to install previous version
peterpeterparker Apr 14, 2018
e9a84b9
Spelling
peterpeterparker Apr 14, 2018
d372cb7
Update iOS 11.3
peterpeterparker Apr 14, 2018
c598359
Release v1.10.0 - Update Facebook iOS SDK
peterpeterparker Apr 14, 2018
c09ddfd
Change sentences order
peterpeterparker Apr 14, 2018
0ccac44
Fix versioning
peterpeterparker Apr 15, 2018
fcbd511
Add ANDROID_SDK_VERSION preference (#646)
skaman Apr 21, 2018
bddac54
Add note regarding PR #646
peterpeterparker Apr 21, 2018
462949b
Format
peterpeterparker Apr 21, 2018
0fe5708
Open changelog v1.11.0
peterpeterparker Apr 21, 2018
61ee356
Format
peterpeterparker Apr 21, 2018
f0bee56
Format
peterpeterparker Apr 21, 2018
8756dc7
Format
peterpeterparker Apr 21, 2018
efffde9
#645: Remove App Invites
peterpeterparker Apr 21, 2018
bd2f91c
Next version 1.11.0
peterpeterparker Apr 21, 2018
21229fe
App Invites removal is a breaking change, next version 2.0.0
peterpeterparker Apr 21, 2018
c7a4cbc
Add notice for older Cordova CLI
peterpeterparker Apr 26, 2018
b594d32
#568: Fix null pointer exception crashing app after 2nd login
peterpeterparker Apr 28, 2018
be84f8b
#653: Update Facebook iOS SDK v4.33.0
peterpeterparker May 4, 2018
9535ae7
Release v2.1.0
peterpeterparker May 4, 2018
7bda783
Create issue_template.md (#668)
jeduan Jun 1, 2018
f3c7ffe
Typings and a bit of more details
peterpeterparker Jun 1, 2018
ec79844
Typings
peterpeterparker Jun 1, 2018
74bccb1
Update Facebook iOS SDK 4.34.0
peterpeterparker Jun 27, 2018
b7963e2
Release v2.2.0
peterpeterparker Jun 27, 2018
d04a90d
update from upstream
DrMoriarty Jul 24, 2018
27a799f
remove ANDROID_SDK_VERSION parameter
DrMoriarty Jul 24, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .cordova/config.json

This file was deleted.

38 changes: 38 additions & 0 deletions .github/issue_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
Please do not submit support requests or "How to" questions here. Instead, please use channels like [StackOverflow](http://stackoverflow.com/) or the [Ionic forum](https://forum.ionicframework.com)

For issues or feature requests related to the code **in this repository** file a Github issue and provide as much details as possible

**Bug or feature request**

[ ] I'm reporting a reproducible issue with the code
[ ] I'm reporting a feature request

**Describe the Bug of feature request**

A clear and concise description of what the bug or feature request is

**Expected Behavior**

A clear and concise description of what you expected to happen

**Plugin version, OS, devices, etc**

Please provide information about the plugin version, OS, devices etc. where you faced your issue

**Sample repo**

A sample repo will dramatically decrease the time needed for this issue to be fixed, if you could, please provide one in order to reproduce the problem

Alternatively, provide a link to the source code of your app

**Additional Context**

List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to fix, Stack Overflow links, forum links, screenshots, OS if applicable, etc.

**Important note**

Unfortunately since this is a project done in spare time, support requests or "How to" questions will be closed without any further comments

If we consider your issue to not be well documented, it will be closed without further comments too

Thx you in advance for your understanding
7 changes: 6 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,9 @@ gen/
build/

local.properties
proguard/
proguard/

.idea
*.iml
/nbproject/private/
nbproject
77 changes: 77 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
<a name="2.2.0"></a>
# [2.2.0](https://github.com/jeduan/cordova-plugin-facebook4/releases/tag/v2.2.0)

## Features

* **iOS:** Update Facebook iOS SDK v4.34.0 ([74bccb1](https://github.com/jeduan/cordova-plugin-facebook4/commit/74bccb1a4f8938024002d0f4e681b9a56b1d7f43) | [Facebook changelog](https://developers.facebook.com/docs/ios/change-log-4x))

<a name="2.1.0"></a>
# [2.1.0](https://github.com/jeduan/cordova-plugin-facebook4/releases/tag/v2.1.0)

## Features

* **iOS:** Update of the Facebook SDK v4.33.0 for iOS 11 ([#653](https://github.com/jeduan/cordova-plugin-facebook4/issues/653))

<a name="2.0.1"></a>
# [2.0.1](https://github.com/jeduan/cordova-plugin-facebook4/releases/tag/v2.0.1)

## Bug fixes

* **Android:** Fix null pointer exception leading to app crashing after a second login (flow example: login -> graphApi -> logout -> login -> crash) ([#568](https://github.com/jeduan/cordova-plugin-facebook4/issues/568))

<a name="2.0.0"></a>
# [2.0.0](https://github.com/jeduan/cordova-plugin-facebook4/releases/tag/v2.0.0)

**Breaking change:** As of February 5, 2018, Facebook doesn't support anymore App Invites, therefore these methods have been removed.

This version introduce also a new optional variable for the Android installation.

## Features

* **iOS:** App Invites support removed ([#645](https://github.com/jeduan/cordova-plugin-facebook4/issues/645))

* **Android:** Add optional installation variable `ANDROID_SDK_VERSION` ([#550](https://github.com/jeduan/cordova-plugin-facebook4/issues/550))([#646](https://github.com/jeduan/cordova-plugin-facebook4/pull/646))

### Side note

I did consider removing the methods for App Invites as a breaking change, even if these weren't already supported from Facebook since months.

I followed the semantic versioning idea the Ionic team recently published in their [blog](https://blog.ionicframework.com/ionic-semantic-versioning-release-schedule-and-lts/)

@peterpeterparker

<a name="1.10.1"></a>
# [1.10.1](https://github.com/jeduan/cordova-plugin-facebook4/releases/tag/v1.10.1)

v1.10.1 Fix an issue regarding the versioning (v1.10 was missing in plugin.xml)

<a name="1.10.0"></a>
# [1.10.0](https://github.com/jeduan/cordova-plugin-facebook4/releases/tag/v1.10.0)

v1.10.0 introduces the last Facebook SDK for iOS

## Features

* **iOS:** Update of the Facebook SDK v4.31.1 for iOS 11 ([#631](https://github.com/jeduan/cordova-plugin-facebook4/issues/631)) ([#634](https://github.com/jeduan/cordova-plugin-facebook4/pull/634))

* **Android:** Add a note in the README and Android Guide about the compatibility with cordova-android >= v7.0.0

### Disclaimer

The introduction of the new Facebook SDK for iOS 11 add a new confirm modal to the login flow.

This is the expected design flow defined by `Apple` which `Facebook` implemented. The `cordova-plugin-facebook4` can't modify this behavior (as far as I know, @peterpeterparker).

#### iOS 11.3

On iOS 11.3, the user won't have the choice anymore between using the Facebook App or using Email/Phone number for Facebook login process but will go straight to the "Facebook - Accept permissions" screen.

Therefore, with this version, the user will still face only one modal during the login flow.

#### iOS >= 11 < 11.3

Because of the introduction of the new modal, the user might face two modals during the login flow. One asking him/her if he/she want to open Facebook and one again asking him/her as before if he/she want to open the Facebook App.

About the subject, you could for example have a look to this [stackoverflow's post](https://stackoverflow.com/questions/45858774/ios-11-facebook-signin-is-showing-an-initial-system-alert/).

This is improved with iOS 11.3.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ These are just guidelines, not rules, use your best judgement and feel free to p

Before creating a Github issue make sure you...

- Check the [Troubleshooting Guide](TROUBLESHOOTING.md) for well known issues.
- Check the [Troubleshooting Guide](./docs/TROUBLESHOOTING.md) for well known issues.
- Search the [issues list](https://github.com/Wizcorp/phonegap-facebook-plugin/issues) for existing closed or still open issues
- Create a Github issue

Expand Down
Loading