Skip to content

Commit

Permalink
fix broken unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sdottaka committed Jan 29, 2017
1 parent 14d87c8 commit d94fa7c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
2 changes: 2 additions & 0 deletions Testing/GoogleTest/Encoding/charsets_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ namespace
CharsetsTest()
{
// You can do set-up work for each test here.
charsets_init();
}

virtual ~CharsetsTest()
{
// You can do clean-up work that doesn't throw exceptions here.
charsets_cleanup();
}

// If the constructor and destructor are not enough for setting up
Expand Down
3 changes: 3 additions & 0 deletions Testing/GoogleTest/Encoding/codepage_detect_test.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include <gtest/gtest.h>
#include "codepage_detect.h"
#include "charsets.h"

namespace
{
Expand All @@ -13,11 +14,13 @@ namespace
CodepageDetectTest()
{
// You can do set-up work for each test here.
charsets_init();
}

virtual ~CodepageDetectTest()
{
// You can do clean-up work that doesn't throw exceptions here.
charsets_cleanup();
}

// If the constructor and destructor are not enough for setting up
Expand Down
4 changes: 2 additions & 2 deletions Testing/GoogleTest/Paths/paths_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ namespace
}
TEST_F(PathTest, Exists_relfiles)
{
const TCHAR path[] = _T(".\\..\\Paths\\paths::test.cpp");
const TCHAR path2[] = _T("..\\Paths\\paths::test.cpp");
const TCHAR path[] = _T(".\\..\\Paths\\paths_test.cpp");
const TCHAR path2[] = _T("..\\Paths\\paths_test.cpp");
EXPECT_EQ(paths::IS_EXISTING_FILE, paths::DoesPathExist(path));
EXPECT_EQ(paths::IS_EXISTING_FILE, paths::DoesPathExist(path2));
}
Expand Down
4 changes: 2 additions & 2 deletions Testing/GoogleTest/UnitTests/UnitTests.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<ClCompile>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>..\..\..\Src;..\..\..\Src\Common;..\..\..\Externals\boost;..\..\..\Externals\poco\Foundation\include;..\..\..\Externals\poco\XML\include;..\..\..\Externals\gtest\include;..\..\..\Externals\gtest\;..\..\..\Src\diffutils\src;..\..\..\Src\diffutils\lib;..\..\..\Src\diffutils\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<PreprocessorDefinitions>WIN32;_DEBUG;_CONSOLE;UNICODE;POCO_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<PreprocessorDefinitions>WIN32;WIN64;_DEBUG;_CONSOLE;UNICODE;POCO_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<BasicRuntimeChecks>EnableFastChecks</BasicRuntimeChecks>
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
<TreatWChar_tAsBuiltInType>true</TreatWChar_tAsBuiltInType>
Expand Down Expand Up @@ -153,7 +153,7 @@
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
<ClCompile>
<AdditionalIncludeDirectories>..\..\..\Src;..\..\..\Src\Common;..\..\..\Externals\boost;..\..\..\Externals\poco\Foundation\include;..\..\..\Externals\poco\XML\include;..\..\..\Externals\gtest\include;..\..\..\Externals\gtest\;..\..\..\Src\diffutils\src;..\..\..\Src\diffutils\lib;..\..\..\Src\diffutils\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<PreprocessorDefinitions>WIN32;NDEBUG;_CONSOLE;UNICODE;POCO_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<PreprocessorDefinitions>WIN32;WIN64;NDEBUG;_CONSOLE;UNICODE;POCO_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<RuntimeLibrary>MultiThreaded</RuntimeLibrary>
<TreatWChar_tAsBuiltInType>true</TreatWChar_tAsBuiltInType>
<PrecompiledHeader>
Expand Down

0 comments on commit d94fa7c

Please sign in to comment.