Merge pull request #37 from Wikia/XW-4569

XW-4569 | Add logging, remove number from video-select
Wikia · Feb 26, 2018 · 240b72d · 240b72d
2 parents 1afb36d + 7121fe8
commit 240b72d
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 10 deletions.
diff --git a/dist/dev.css b/dist/dev.css
diff --git a/dist/wikiajwplayer.js b/dist/wikiajwplayer.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jwplayer-fandom",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "JWPlayer for Fandom",
   "main": "index.js",
   "scripts": {

diff --git a/src/events.js b/src/events.js
@@ -1,4 +1,4 @@
-function wikiaJWPlayerEvents(playerInstance, willAutoplay, logger) {
+function wikiaJWPlayerEvents(playerInstance, willAutoplay, logger, playlistId) {
 	var state = getNewState(),
 		wasAlreadyUnmuted = false,
 		depth = 0,
@@ -44,6 +44,13 @@ function wikiaJWPlayerEvents(playerInstance, willAutoplay, logger) {
 		var positionFloor = Math.floor(data.position),
 			percentPlayed = Math.floor(positionFloor * 100 / data.duration);
 
+		if (percentPlayed > 100) {
+			data.mediaId = playerInstance.getPlaylistItem().mediaid;
+			data.playlistId = playlistId;
+
+			logger.error('played-percentage', data);
+		}
+
 		if (positionFloor > state[prefix].progress.durationWatched && positionFloor % 5 === 0) {
 			playerInstance.trigger(prefix + 'SecondsPlayed', { value: positionFloor });
 

diff --git a/src/index.js b/src/index.js
@@ -48,6 +48,7 @@ window.wikiaJWPlayer = function (elementId, options, callback) {
 	 * @param elementId
 	 * @param options
 	 * @param logger
+	 * @param lang
 	 * @param i18n
 	 * @return {*}
 	 */
@@ -119,15 +120,15 @@ window.wikiaJWPlayer = function (elementId, options, callback) {
 
 		wikiaJWPlayerIdleScreen(playerInstance, i18n);
 		wikiaJWPlayerReplaceIcons(playerInstance);
-		wikiaJWPlayerEvents(playerInstance, options.autoplay, logger);
+		wikiaJWPlayerEvents(playerInstance, options.autoplay, logger, options.related.playlistId);
 
 		if (options.related) {
 			wikiaJWPlayerRelatedVideoSound(playerInstance);
 		}
 
 		if (options.tracking) {
 			options.tracking.pixel = options.videoDetails.playlist[0].pixel;
-			wikiaJWPlayerTracking(playerInstance, options.autoplay, options.tracking);
+			wikiaJWPlayerTracking(playerInstance, options.autoplay, options.tracking, logger, options.related.playlistId);
 		}
 
 		wikiaJWPlayerHandleTabNotActive(playerInstance, options.autoplay);

diff --git a/src/tracking.js b/src/tracking.js
@@ -1,4 +1,4 @@
-function wikiaJWPlayerTracking(playerInstance, willAutoplay, tracker) {
+function wikiaJWPlayerTracking(playerInstance, willAutoplay, tracker, logger, playlistId) {
 	//This will replace 'trackingevent' in internal tracker url path
 	var eventName = 'videoplayerevent',
 		gaCategory = tracker.category || 'featured-video',
@@ -107,10 +107,17 @@ function wikiaJWPlayerTracking(playerInstance, willAutoplay, tracker) {
 			data.item
 		);
 
-		var labelPrefix = data.auto ? 'recommended-video-autoplay-' : 'recommended-video-select-';
+		if (data.auto && data.position > 0) {
+			data.mediaId = playerInstance.getPlaylistItem().mediaid;
+			data.playlistId = playlistId;
+
+			logger.error('recommended-video-autoplay', data)
+		}
+
+		var labelPrefix = data.auto ? 'recommended-video-autoplay' : 'recommended-video-select-' + data.position;
 
 		track({
-			label: labelPrefix + data.position,
+			label: labelPrefix,
 			action: 'impression'
 		});