Skip to content

Commit

Permalink
Merge pull request #47 from Wikia/XW-4735
Browse files Browse the repository at this point in the history
XW-4735 | Debug level for logger
  • Loading branch information
JamesHawking authored Apr 9, 2018
2 parents 00c2154 + 471e83a commit 0b8ea7f
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 5 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ Id of DOM element where the player should be placed
logger: {
// logging level, default is error, available values: 'info', 'warn', 'error', 'off'
logLevel: string,
// should debug logs be logged to event-logger service?
logDebugToService: boolean,
// client name (will be passed into logging service) e.g. 'oasis', 'mobile-wiki'
clientName: string,
// client version
Expand Down
2 changes: 1 addition & 1 deletion dist/wikiajwplayer.js

Large diffs are not rendered by default.

22 changes: 18 additions & 4 deletions src/logger.js
Original file line number Diff line number Diff line change
@@ -1,26 +1,29 @@
function wikiaJWPlayerLogger(options) {
var servicesDomain = options.servicesDomain || 'services.wikia.com',
loggerPath = '/event-logger/error',
loggerPath = '/event-logger/',
loggerUrl = 'https://' + servicesDomain + loggerPath,
prefix = 'JWPlayer',
logLevels = {
debug: 0,
info: 1,
warn: 2,
error: 3,
off: 4
},
loggerOptions = options.logger || {},
logLevel = loggerOptions.logLevel ? logLevels[loggerOptions.logLevel] : logLevels['error'],
logDebugToService = loggerOptions.logDebugToService,
clientName = loggerOptions.clientName,
clientVersion = loggerOptions.clientVersion;

/**
* logs errors to event-logger service
*
* @param resource - 'debug' or 'error'
* @param name
* @param description
*/
function logErrorToService(name, description) {
function logToService(resource, name, description) {
var request = new XMLHttpRequest(),
data = {
name: prefix + ' ' + name
Expand All @@ -38,12 +41,21 @@ function wikiaJWPlayerLogger(options) {
data.client_version = clientVersion;
}

request.open('POST', loggerUrl, true);
request.open('POST', loggerUrl + resource, true);
request.setRequestHeader('Content-type', 'application/json');

request.send(JSON.stringify(data));
}

function debug(name, description) {
if (logLevel <= logLevels['debug']) {
console.log(prefix, name, description);
}

if (logDebugToService) {
logToService('debug', name, description);
}
}

function info(name, description) {
if (logLevel <= logLevels['info']) {
Expand All @@ -60,7 +72,8 @@ function wikiaJWPlayerLogger(options) {
function error(name, description) {
if (logLevel <= logLevels['error']) {
console.error(prefix, name, description);
logErrorToService(name, description);

logToService('error', name, description);
}
}

Expand All @@ -80,6 +93,7 @@ function wikiaJWPlayerLogger(options) {
}

return {
debug: debug,
info: info,
warn: warn,
error: error,
Expand Down

0 comments on commit 0b8ea7f

Please sign in to comment.