Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build #95

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Update Build #95

merged 2 commits into from
Nov 5, 2021

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Nov 4, 2021

Overview

This project was not building because of outdated dependencies. This updates them.

Testing Instructions

  • Ensure you have Java 8 installed on your system
    brew install java
  • Check out this branch and run update
    • Ensure it succeeds
  • Run server
  • From another tab, send a sample request (using http or xh or curl) to the /multi endpoint
    http :8090/multi < examples/MultiOperationRequest.json
    • Ensure it succeeds

Bintray was sunset a few years ago and all the previous versions
were deleted 😬. Since we don't actively use Spark
JobServer anymore, it is safe to upgrade it to a nearby version.

For more details see: https://github.com/spark-jobserver/spark-jobserver#version-information
Copy link

@emilyhu0106 emilyhu0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is working successfully, but needs additional setups

  1. The build requires Java 8, but brew install java is for java 11. Use
brew tap adoptopenjdk/openjdk
brew install --cask adoptopenjdk8

to install Java 8

  1. When I run update, I got The operation couldn't be completed. Unable to locate a Java Runtime. error after installing Java. Need to install autoconf and run
sudo ln -sfn /usr/local/opt/openjdk/libexec/openjdk.jdk /Library/Java/JavaVirtualMachines/openjdk.jdk

to successfully run update

@rajadain
Copy link
Member Author

rajadain commented Nov 4, 2021

Thanks, I created #96 to update the README and reflect those requirements.

@rajadain
Copy link
Member Author

rajadain commented Nov 4, 2021

We can't add those steps into a setup script because they are macOS specific, and this project could be run on Linux machines as well.

What changes would you like in the code of this PR before it is approved?

@emilyhu0106 emilyhu0106 self-requested a review November 5, 2021 16:34
@rajadain rajadain merged commit f97ed66 into develop Nov 5, 2021
@rajadain rajadain deleted the tt/fix-build branch November 5, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants