Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Footer #68

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Added Footer #68

merged 4 commits into from
Jan 19, 2024

Conversation

AbhineshJha
Copy link
Contributor

@AbhineshJha AbhineshJha commented Jan 19, 2024

Fixes #61

Added the footer on the webpage

image

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doodle-collab ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 8:20am

@ItsRoy69
Copy link
Collaborator

Hey @AbhineshJha eventhough it looks good to me, but can you just make another folder inside contants folder named as "Footer" where you can add the footer file

@AbhineshJha
Copy link
Contributor Author

@ItsRoy69 fixeddd !!!

@ItsRoy69
Copy link
Collaborator

@AbhineshJha you are declaring the footer folder inside navbar folder, kindly fix it and keep the footer folder inside constants folder instead

@AbhineshJha
Copy link
Contributor Author

AbhineshJha commented Jan 19, 2024

sir there is already a folder named footer in constant folder..
so when i create a folder under constant , it automatically goes under navbar
image
@ItsRoy69

@AbhineshJha
Copy link
Contributor Author

Now check @ItsRoy69

@ItsRoy69
Copy link
Collaborator

LGTM

@ItsRoy69 ItsRoy69 merged commit fa914bc into WikiPortal:main Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Footer
2 participants