Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add attribute syncing #276

Merged
merged 6 commits into from
Apr 10, 2024
Merged

feat: Add attribute syncing #276

merged 6 commits into from
Apr 10, 2024

Conversation

WiIIiam278
Copy link
Owner

Closes #219. Closes #249.

Adds support for syncing attributes applied to players, including modifiers and instances and fixes issues related to health and max health syncing.

The following data values which can be attributed to the player will now be properly synced:

  • Flight speed
  • Movement speed
  • Luck
  • Knockback resistance
  • Mob pathfind follow range
  • Knockback
  • Attack speed
  • Max absorption (1.20.2+)
    This means that plugins/commands modifying player attributes directly will now be correctly synced cross-server. This system now also better takes into account modifiers from equipment and potion effects.

This also futureproofs support for syncing these newly customizable values coming in 1.20.5/1.21:

  • Block breaking speed
  • Entity/block mining range ("reach")
  • Step height
  • Jump strength
  • Distance you can fall without taking fall damage
  • Fall damage calculation multiplier
  • Gravitational pull

@WiIIiam278 WiIIiam278 self-assigned this Apr 10, 2024
@WiIIiam278 WiIIiam278 changed the title feat: add attribute syncing feat: Add attribute syncing Apr 10, 2024
@WiIIiam278 WiIIiam278 merged commit 676ba7a into master Apr 10, 2024
@WiIIiam278 WiIIiam278 deleted the feat/attributes branch April 10, 2024 18:38
@WiIIiam278 WiIIiam278 mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health syncing not working Syncing max health doesn't work properly in certain circumstances
1 participant