Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a small problem in build script #258

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

SnowCutieOwO
Copy link
Contributor

I ran this script by myself and Gradle told me that there's an error in line 170
I checked and found that the tag placeholder will try to fetch even if grgit is none. So I changed the place of this part of code.
Now it could run normally.
Thanks! :)

@SnowCutieOwO SnowCutieOwO reopened this Mar 12, 2024
Copy link
Owner

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure. I expect most people to clone this anyway to build but you're right that the code is written such that the grgit failsafe is unreachable (lol). Pretty sure this also effects literally every other one of my projects (lol)

@WiIIiam278 WiIIiam278 merged commit b77cf25 into WiIIiam278:master Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants