Add PostgreSQL, MongoDB Atlas & MongoDB Replica Set Support #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me, tested and working
…ull not null not null not null not null not null not null not null not null not null not null not null not null not null not null not null not null
# Conflicts: # common/src/main/java/net/william278/husksync/database/MongoDbDatabase.java # common/src/main/java/net/william278/husksync/database/mongo/MongoCollectionHelper.java # common/src/main/java/net/william278/husksync/database/mongo/MongoConnectionHandler.java
WiIIiam278
requested changes
Mar 8, 2024
ProdPreva1l
changed the title
…ate the config example in docs, also updates mongodb driver bc apparently i was special and very very out of data
|
Passing all tests, tested for Atlas and Postgres, also adds a safety check for UUID types on mongodb |
|
dont merge, resolving an issue, appears to be that sasl1 auth is goofd |
WiIIiam278
requested changes
Mar 16, 2024
Comment on lines
69
to
72
| String baseURI = "mongodb+srv://{0}:{1}@{2}/?retryWrites=true&w=majority"; | ||
| baseURI = baseURI.replace("{0}", credentials.getUsername()); | ||
| baseURI = baseURI.replace("{1}", credentials.getPassword()); | ||
| baseURI = baseURI.replace("{2}", credentials.getHost()); |
There was a problem hiding this comment.
Suggested change
| String baseURI = "mongodb+srv://{0}:{1}@{2}/?retryWrites=true&w=majority"; | |
| baseURI = baseURI.replace("{0}", credentials.getUsername()); | |
| baseURI = baseURI.replace("{1}", credentials.getPassword()); | |
| baseURI = baseURI.replace("{2}", credentials.getHost()); | |
| final Database.Type type = plugin.getSettings().getDatabase().getType(); | |
| if (type == Type.MONGO_ATLAS) { | |
| final String uri = String.format("%s://%s:%s@%s/?retryWrites=true&w=majority", | |
| type.getProtocol(), credentials.getUsername(), credentials.getPassword(), credentials.getHost()); |
There was a problem hiding this comment.
I was going to switch to String.format, but my way makes more sense in the new implementation
| MONGO("MongoDB", "mongo"); | ||
| POSTGRES("PostgreSQL", "postgresql"), | ||
| MONGO("MongoDB", "mongo"), | ||
| MONGO_ATLAS("MongoDB", "atlas"); |
There was a problem hiding this comment.
Suggested change
| MONGO_ATLAS("MongoDB", "atlas"); | |
| MONGO_ATLAS("MongoDB", "mongodb+srv"); |
There was a problem hiding this comment.
This has been removed in favour of a mongo_settings configuration section
…nly**, allows for MongoDB Atlas, normal MongoDb AND MongoDB replica sets via the parameters in advanced mongo settings, added try and catch on all mongo operations so that it actually throws instead of a cutsie little warning
|
Breaks config for MongoDB users only |
ProdPreva1l
changed the title
… step from docs for atlas users
… if using mongodb atlas
WiIIiam278
approved these changes
Mar 16, 2024
|
Nice work. Thats a better way of doing mongo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for PostgreSQL.
Uses all better native postgre alternatives
Adds support for srv record based mongodb atlas