Exception strings #12975
Open
Exception strings #12975
+569
−421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1389,7 +1408,8 @@ | |||
| try: | |||
| parse_query(query_string) | |||
| except Exception as error: | |||
| raise ValidationError(f"Could not parse query string: {error}") from error | |||
| msg = f"Could not parse query string: {error}" | |||
| raise ValidationError(msg) from error | |||
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
| @@ -1505,7 +1525,8 @@ | |||
| try: | |||
| parse_query(query_string) | |||
| except Exception as error: | |||
| raise ValidationError(f"Could not parse query string: {error}") from error | |||
| msg = f"Could not parse query string: {error}" | |||
| raise ValidationError(msg) from error | |||
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12975 +/- ##
==========================================
- Coverage 91.09% 90.87% -0.23%
==========================================
Files 598 598
Lines 61450 61684 +234
Branches 6373 6373
==========================================
+ Hits 55980 56054 +74
- Misses 3805 3965 +160
Partials 1665 1665
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Other information