Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(addons): fix bulk edit form construction #12961

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 7, 2024

Proposed changes

Correctly use project scoping when available, see #12957

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.9 milestone Nov 7, 2024
@nijel nijel self-assigned this Nov 7, 2024
@nijel nijel enabled auto-merge (rebase) November 7, 2024 14:11
Correctly use project scoping when available, see WeblateOrg#12957
@nijel nijel merged commit a888c74 into WeblateOrg:main Nov 7, 2024
29 checks passed
@nijel nijel deleted the bulk-types branch November 7, 2024 17:02
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.10%. Comparing base (3df5a7c) to head (8ebeda1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
weblate/addons/forms.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12961      +/-   ##
==========================================
- Coverage   91.11%   91.10%   -0.01%     
==========================================
  Files         598      598              
  Lines       61433    61439       +6     
  Branches     6368     6370       +2     
==========================================
+ Hits        55972    55976       +4     
- Misses       3798     3799       +1     
- Partials     1663     1664       +1     
Files with missing lines Coverage Δ
weblate/trans/forms.py 89.90% <100.00%> (ø)
weblate/addons/forms.py 93.66% <75.00%> (-0.76%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant