Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete request and present methods #287

Merged

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Oct 16, 2024

Closes #285

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.55%. Comparing base (5801e63) to head (db44acd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   83.93%   83.55%   -0.38%     
==========================================
  Files          48       48              
  Lines        4257     4215      -42     
  Branches     1051     1055       +4     
==========================================
- Hits         3573     3522      -51     
- Misses        656      663       +7     
- Partials       28       30       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for the cleanup and to @iFergal for the clarifying comments on the issue.

@rodolfomiranda rodolfomiranda merged commit 32ceda1 into WebOfTrust:main Oct 16, 2024
8 checks passed
@lenkan lenkan deleted the chore-remove-obosolete-methods branch October 16, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete methods for credential presentation
3 participants