Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement typings in ending module #280

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Sep 15, 2024

As a continuation from #279, I fixed the typings for the end/ending.ts module.

Also split the tests up in to smaller tests to make it easier to follow what the module is doing. In that I added some more test cases that were missing.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (5801e63) to head (242c8d9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/keri/end/ending.ts 86.27% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   83.93%   83.84%   -0.10%     
==========================================
  Files          48       48              
  Lines        4257     4258       +1     
  Branches     1051     1057       +6     
==========================================
- Hits         3573     3570       -3     
- Misses        656      660       +4     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodolfomiranda rodolfomiranda merged commit 8597038 into WebOfTrust:main Oct 8, 2024
8 checks passed
@lenkan lenkan deleted the chore-typings-ending branch October 8, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants