Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential issuance and IPEX grant message for multisig participants #118

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

pfeairheller
Copy link
Member

This PR includes:

  • Implementation of IPEX grant message
  • Updates to credential issue to support multisig issuance
  • A new script located in examples/scripts called multisig-create-credential.ts that is a peer to the exact same script (but ends in .py) in SigPy. It can be run with multisig-signify-issue.sh from KERIpy to create a multisig issuer, create a credential registry, create a credential and GRANT it to the holder via IPEX as a participant in a 3 way multisig AID.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #118 (5a6303f) into development (90324e2) will decrease coverage by 0.13%.
The diff coverage is 72.91%.

@@               Coverage Diff               @@
##           development     #118      +/-   ##
===============================================
- Coverage        80.92%   80.79%   -0.13%     
===============================================
  Files               42       42              
  Lines             4078     4109      +31     
  Branches          1022     1023       +1     
===============================================
+ Hits              3300     3320      +20     
- Misses             746      757      +11     
  Partials            32       32              
Files Coverage Δ
src/keri/app/clienting.ts 90.68% <100.00%> (+0.11%) ⬆️
src/keri/app/exchanging.ts 98.24% <100.00%> (ø)
src/keri/core/eventing.ts 72.28% <0.00%> (ø)
src/keri/app/credentialing.ts 85.54% <73.80%> (-3.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@m00sey
Copy link
Member

m00sey commented Oct 17, 2023

Happy to merge this and I can work on coverage

@m00sey m00sey merged commit f17f5f1 into WebOfTrust:development Oct 17, 2023
3 of 4 checks passed
@pfeairheller pfeairheller deleted the feat-ms-iss branch October 17, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants