Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agent config retrieval #318

Merged

Conversation

iFergal
Copy link
Collaborator

@iFergal iFergal commented Nov 8, 2024

Simple endpoint to retrieve the agent JSON config.

The motivation for this is a really low effort way to discover the witnesses etc that KERIA is aware of when deployed, as described in #301. There might be better solutions that this but it will be OK for my needs for now.

This allows a Signify client to discover from iurls witnesses, watchers etc, provided the OOBI URLs are given an appropriate tag as a query param.

I only exposed iurls but named it as a config endpoint so more can be exposed in the future if it makes sense.

@iFergal iFergal requested a review from 2byrds November 8, 2024 20:57
@iFergal iFergal self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (18d3ad7) to head (9c5d59d).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   93.06%   93.76%   +0.70%     
==========================================
  Files          36       36              
  Lines        7121     8001     +880     
==========================================
+ Hits         6627     7502     +875     
- Misses        494      499       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@2byrds 2byrds merged commit 9736fcb into WebOfTrust:main Nov 8, 2024
5 checks passed
@iFergal iFergal deleted the feat/agentConfigRetrieval branch November 8, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants