Updated CESR 2.0 code tables to match keripy #161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 95.42% 95.47% +0.04%
==========================================
Files 32 32
Lines 3037 3069 +32
==========================================
+ Hits 2898 2930 +32
Misses 139 139 ☔ View full report in Codecov by Sentry. |
daidoji
changed the title
|
Changing to draft, this work is on hold until Sam completes work. WebOfTrust/cesr-ts#17 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Starting work on upgrading CESR to 2.0 version as detailed in #160
Testing
Updated naive code table tests but that's about it. Still have questions about how cesride was tested against keripy in #cesr channel on discord.
For Reviewers
Cargo.toml