Avoid measurement dead-spot between sync and async phase #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could potentially miss a
gc
between theperformance.mark
calls forsyncEndTime
andasyncStartTime
.This PR changes the code to reuse the sync end times and marker for the async start.
This means we'll now also measure one additional
performance.mark
call.An alternative would be to replace
const syncEndTime = performance.now();
withconst syncEndTime = performance.mark(syncEndLabel).startTime;
to have the same timestamp and one call less.
Summary 5 runs:
I have to re-run the detailed measurements tonight when my machine is not in use to reduce noise.