Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust dot size to iterationCount #356

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Adjust dot size to iterationCount #356

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f93caf
adjust dot size
camillobruni Jan 25, 2024
6a8d586
adding stuff
camillobruni Jan 25, 2024
26f444c
remove space
camillobruni Jan 25, 2024
bc934b4
remove newline
camillobruni Jan 25, 2024
2faaa64
reverting to 2px min size
camillobruni Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion resources/metric-ui.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,12 @@ function renderScatterPlot({ values, width = 500, height, trackHeight, xAxisPosi
// Axis + labels height:
const axisHeight = 18;
const axisMarginY = 4;
const markerSize = 5;
const trackMargin = 2;
let markerSize = 5;
// Auto-adjust markers to [2px, 5px] for high iteration counts:
camillobruni marked this conversation as resolved.
Show resolved Hide resolved
const iterationsLimit = 20;
if (values.length > iterationsLimit)
markerSize = 1 + (4 / values.length) * iterationsLimit;
camillobruni marked this conversation as resolved.
Show resolved Hide resolved
// Recalculate height:
if (height)
trackHeight = (height - axisHeight - axisMarginY) / trackCount;
Expand Down
Loading