Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cython override #37

Open
wants to merge 2 commits into
base: bump-nixpkgs-2019-11-21
Choose a base branch
from
Open

Add cython override #37

wants to merge 2 commits into from

Conversation

matthewbauer
Copy link
Contributor

Adds an override to cython, dropping gdb support.

@matthewbauer
Add busybox-sandbox-shell override
3736dc4 
Weird issue happens when combining cross overlays and pkgsStatic
together. Some issue when combining the two together.

This was introduced in
NixOS/nixpkgs@39769df.

/cc @Ericson2314
@matthewbauer
Don’t include gdb in Cython
4e39624 
Cython depends on gdb but we can’t build it targetting wasm32.
Luckily, gdb is an optional dependency of Cython, so just setting it
to null works. We don’t get the cython debugger, but we don’t need it
anyway.
@matthewbauer matthewbauer mentioned this pull request Dec 3, 2019
Closed
@dfordivam
Copy link
Member

Thanks Matt, but there was indeed an issue with the wasm-cross expressions which caused the gdb to be built for the target wasm. Its important to use two layers of buildPackages here

  lndir ${buildPackages.buildPackages.webabi}/lib/node_modules/webabi/build $out

This is the way existing wasm-cross uses webabi.
But because the busybox issue is not dependent on this, we (me and Will) thought that using it two times is redundant, and I got rid of it.

And infact this was the only change required to make cross-compilation work after I pulled in your fix from #33

@matthewbauer
Copy link
Contributor Author

Thanks Matt, but there was indeed an issue with the wasm-cross expressions which caused the gdb to be built for the target wasm. Its important to use two layers of buildPackages here

  lndir ${buildPackages.buildPackages.webabi}/lib/node_modules/webabi/build $out

This is the way existing wasm-cross uses webabi.
But because the busybox issue is not dependent on this, we (me and Will) thought that using it two times is redundant, and I got rid of it.

And infact this was the only change required to make cross-compilation work after I pulled in your fix from #33

Yeah that sounds good!

@ElvishJerricco
Copy link
Member

Why was this not an issue before?

@dfordivam
Copy link
Member

it seems that even with this fix the build fails

checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... Invalid configuration `wasm32-unknown-unknown-wasm': system `unknown-wasm' not recognized
configure: error: /nix/store/b34zjdmq5l8k6rwdykjx55yl9r9isl8k-bash-4.4-p23/bin/bash ./config.sub wasm32-unknown-unknown-wasm failed
builder for '/nix/store/vs01dqdawnfsdgjl4m2ww3rbvdrm3rm2-wasm32-unknown-unknown-wasm-gdb-8.3.1.drv' failed with exit code 1
cannot build derivation '/nix/store/536arcij8c5k58w81glgq2xdlxn0n4ip-python2.7-Cython-0.29.13.drv': 1 dependencies couldn't be built

@matthewbauer
Copy link
Contributor Author

Why was this not an issue before?

Cython was added to python lxml here: https://github.com/nixos/nixpkgs/commits/e1b6b9056d4

@dfordivam dfordivam mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewbauer @dfordivam @ElvishJerricco