Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari 18.2 updates #406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Safari 18.2 updates #406

wants to merge 1 commit into from

Conversation

chicoxyzzy
Copy link
Member

Safari 18.2 is still in beta, so let's wait until Sequoia 15.2 and iOS 18.2 are released before merging this one.

https://developer.apple.com/documentation/safari-release-notes/safari-18_2-release-notes

Copy link
Collaborator

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for being on top of things.

@tomayac
Copy link
Collaborator

tomayac commented Nov 7, 2024

I let you merge this once it's released.

@dschuff
Copy link
Member

dschuff commented Nov 7, 2024

Actually I don't see wasmgc in the release notes, have you tested on the beta?

@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Nov 7, 2024

@dschuff it's here in the release notes https://developer.apple.com/documentation/safari-release-notes/safari-18_2-release-notes#Web-Assembly

wasm-feature-detect test passes on Safari 18.2 beta
image

@dschuff
Copy link
Member

dschuff commented Nov 7, 2024

ah thanks i just missed it.

@CryZe
Copy link
Contributor

CryZe commented Nov 10, 2024

This is missing the Type Reflection proposal, which is also enabled (though partially as far as I understand, maybe we need to check what's missing here). I also had a 18.2 branch in progress where I have it like this:

"typeReflection": ["18.2", "Only supports `WebAssembly.Module.imports` and `WebAssembly.Module.exports`"],

@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Nov 11, 2024

Hmm... the value ["18.2", "Only supports WebAssembly.Module.imports and WebAssembly.Module.exports"] seems incorrect to me. I tend to think that "the partial support is lack of support" is more fair. So maybe it's better to keep it as "flag" as it is currently, and just change the version from Safari TP 202 to Safari 18.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants