This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Update to resources. #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a major new update to this; I'll close this PR and open a new one based on it. |
sunfishcode
added a commit
to sunfishcode/wasi-io
that referenced
this pull request
Sep 12, 2023
- Convert to resources. Use resources instead of `u32`s, remove drop functions, `this` arguments, and rename `subscribe-to-*` to just `subscribe`, as discussed in WebAssembly/wasi-poll#21. - Merge wasi-poll into wasi-io. These two proposals are closely related to each other, so it makes sense to have them together. - While here, tidy up the poll API, incorporating ideas discussed in WebAssembly/wasi-poll#220: - Rename `poll-oneoff` to `poll-list`, and add a `poll-one`. - Change `poll-oneoff`'s return type from `list<bool>` to `list<u32>`, because in the common case, this should allow it to create much smaller allocations.
|
The new PR is WebAssembly/wasi-io#46. |
sunfishcode
added a commit
to sunfishcode/wasi-io
that referenced
this pull request
Sep 12, 2023
- Convert to resources. Use resources instead of `u32`s, remove drop functions, `this` arguments, and rename `subscribe-to-*` to just `subscribe`, as discussed in WebAssembly/wasi-poll#21. - Merge wasi-poll into wasi-io. These two proposals are closely related to each other, so it makes sense to have them together. - While here, tidy up the poll API, incorporating ideas discussed in WebAssembly/wasi-poll#22: - Rename `poll-oneoff` to `poll-list`, and add a `poll-one`. - Change `poll-oneoff`'s return type from `list<bool>` to `list<u32>`, because in the common case, this should allow it to create much smaller allocations.
sunfishcode
added a commit
to WebAssembly/wasi-io
that referenced
this pull request
Sep 29, 2023
* Convert to Resources, and other API cleanups. - Convert to resources. Use resources instead of `u32`s, remove drop functions, `this` arguments, and rename `subscribe-to-*` to just `subscribe`, as discussed in WebAssembly/wasi-poll#21. - Merge wasi-poll into wasi-io. These two proposals are closely related to each other, so it makes sense to have them together. - While here, tidy up the poll API, incorporating ideas discussed in WebAssembly/wasi-poll#22: - Rename `poll-oneoff` to `poll-list`, and add a `poll-one`. - Change `poll-oneoff`'s return type from `list<bool>` to `list<u32>`, because in the common case, this should allow it to create much smaller allocations. * Update to WebAssembly/wit-abi-up-to-date@v14. * Remove the wit-deps check now that we have no dependencies. * Fix more references to `poll-oneoff`. * Mark `poll` arguments as borrowed. * Update to wit-abi-up-to-date@v15.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking a draft PR for now until resources are fully implemented; but this shows a picture of what this API will look like.