Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify behavior when dropping an active output-stream #79

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Clarify behavior when dropping an active output-stream #79

merged 1 commit into from
Jul 15, 2024

Conversation

badeend
Copy link
Contributor

@badeend badeend commented Jun 27, 2024 •
edited
Loading

Whether we like it or not, this is the current wasmtime behavior.

Supersedes #74, but in a less aggressive way ;)

pchickey
pchickey approved these changes Jun 27, 2024
View reviewed changes
Copy link

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. #74 fell off my radar a long time ago, sorry, but we can land this immediately and then consider that addition for 0.2.2

@pchickey
Copy link

Needs the markdown updated for me to merge, though.

@badeend
Copy link
Contributor Author

badeend commented Jul 4, 2024

Ah, yes of course. Done!

@pchickey pchickey merged commit 4acd2e7 into WebAssembly:main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchickey pchickey pchickey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badeend @pchickey