Change readdir from returning bytes to returning a dir-entrys.
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`readdir` returning bytes has been a source of complexity for both libc and engine implementors, with subtle issues about alignment and partial records. Rename `dirent` to `dir-entry` for readability, and revamp it: - Make the name field a proper `string` rather than being represented by trailing bytes in the buffer. - Make the inode field `optional`, so that we can make it optional as discussed in #65 without special-casing zero, which is reportedly a valid inode number on [some filesystems]. And remove the `rewind` parameter, which isn't needed when we return a stream, as users wanting to start at the beginning can just request a new stream. [some filesystems]: https://sourceware.org/pipermail/libc-alpha/2022-September/142059.html
sunfishcode
force-pushed
the
sunfishcode/readdir
branch
from
e569d88
to
1669e26
Compare
sunfishcode
added a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Dec 8, 2022
sunfishcode
added a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Dec 8, 2022
sunfishcode
added a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Dec 8, 2022
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readdirreturning bytes has been a source of complexity for both libc and engine implementors, with subtle issues about alignment and partial records.Rename
direnttodir-entryfor readability, and revamp it:stringrather than being represented by trailing bytes in the buffer.optional, so that we can make it optional as discussed in dirent::d_ino #65 without special-casing zero, which is reportedly a valid inode number on some filesystems.And remove the
rewindparameter, which isn't needed when we return a stream, as users wanting to start at the beginning can just request a new stream.