[GC] Fix trapping on array.new_data of dropped segments of offset > 0 #7124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Nov 27, 2024
src/wasm-interpreter.h
Outdated
| @@ -4023,7 +4023,7 @@ class ModuleRunnerBase : public ExpressionRunner<SubType> { | |||
| const auto& seg = *wasm.getDataSegment(curr->segment); | |||
| auto elemBytes = element.getByteSize(); | |||
| auto end = offset + size * elemBytes; | |||
| if ((size != 0ull && droppedDataSegments.count(curr->segment)) || | |||
| if ((offset + size > 0 && droppedDataSegments.count(curr->segment)) || | |||
There was a problem hiding this comment.
It looks like we should check for overflow as well.
tlively
approved these changes
Nov 27, 2024
Co-authored-by: Thomas Lively <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the size is 0, if the offset is > 0 then we should trap.
@tlively Is it expected there are no spec tests for this combination of GC+bulk memory?