Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More improvements on WAV parser #246

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Conversation

linkyndy
Copy link
Contributor

@linkyndy linkyndy commented Jul 10, 2024

The changes recently introduced (v2.9.0) are too eager and forgiving, meaning that the reading budget almost always gets exceeded for large files. In this iteration we focus on:

  • making sure we detect the file as WAV, regardless of how much metadata can be read
  • ignoring the fact chunk and solely relying on fmt and data to extract/compute the metadata
  • reading as few bytes as possible rather than doing a thorough job extracing/computing all metadata according and not according to the format spec

@linkyndy linkyndy marked this pull request as ready for review July 11, 2024 11:40
Copy link
Contributor

@rcpalacio rcpalacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@RubenWolff-wt RubenWolff-wt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@linkyndy linkyndy merged commit 3409b7e into master Jul 12, 2024
16 checks passed
@linkyndy linkyndy deleted the CORE-1393-improve-wav-parser-2 branch July 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants