Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update error capture method to disable relay connection errors to be catched #443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Feb 20, 2024

Description

  • Update the error handling while subscribing to dApp. Return better messages to the user so they can have feedback in case they have network-related issues.
  • Not capture the Relay connection issues to Sentry

Type of change

  • New feature (non-breaking change which adds functionality)

Fixes/Resolves (Optional)

Sentry issuef

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app-web3inbox ❌ Failed (Inspect) Feb 20, 2024 1:31pm

}

switch (error?.message) {
case errorCodeMessageMap.socketStalled:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it stalls while updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants