chore: initial Playwright tests #313
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris13524
force-pushed
the
chore/add-playwright
branch
2 times, most recently
from
bd54d77 to
77c95ff
Compare
chris13524
force-pushed
the
chore/add-playwright
branch
from
b45eea0 to
b27e659
Compare
| /** | ||
| * Read environment variables from file. | ||
| * https://github.com/motdotla/dotenv | ||
| */ | ||
| // require('dotenv').config(); |
There was a problem hiding this comment.
I'd kinda rather keep it for now since this is early in the usage of Playwright and the example boilerplate might come in handy later. Happy for an engineer to remove/cleanup later themselves if they don't feel they will need it.
| /* Test against mobile viewports. */ | ||
| // { | ||
| // name: 'Mobile Chrome', | ||
| // use: { ...devices['Pixel 5'] }, | ||
| // }, | ||
| // { | ||
| // name: 'Mobile Safari', | ||
| // use: { ...devices['iPhone 12'] }, | ||
| // }, |
There was a problem hiding this comment.
Why is this commented out? Mobile is an important use case.
Do they require specific runners or something?
There was a problem hiding this comment.
These commented out code blocks are just boilerplate what Playwright init sets up, I haven't enabled them in order to test them. Feel free to enable in a subsequent PR.
| /* Test against branded browsers. */ | ||
| // { | ||
| // name: 'Microsoft Edge', | ||
| // use: { ...devices['Desktop Edge'], channel: 'msedge' }, | ||
| // }, | ||
| // { | ||
| // name: 'Google Chrome', | ||
| // use: { ...devices['Desktop Chrome'], channel: 'chrome' }, | ||
| // }, | ||
| ], |
There was a problem hiding this comment.
No need to test for these if we test against chromium
There was a problem hiding this comment.
Co-authored-by: Celine Sarafa <[email protected]>
Co-authored-by: Celine Sarafa <[email protected]>
chris13524
force-pushed
the
chore/add-playwright
branch
from
a8a902e to
ce55984
Compare
chris13524
force-pushed
the
chore/add-playwright
branch
from
ce55984 to
56dc001
Compare
Adds Playwright testing. Initially created with
npm init playwright@latestand then tweaks for yarn, automatic running of the dev server, and added a basic initial test.