Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabbed mode spec #95

Merged
merged 42 commits into from
Apr 29, 2024
Merged

Add tabbed mode spec #95

Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
df02985
Added tabbed to candidate display mode list.
mgiuca Feb 29, 2024
95849ae
Update note.
mgiuca Feb 29, 2024
a72aa40
Added tabbed display mode and tab_strip member.
mgiuca Feb 29, 2024
b8a1e95
Added full details on the tab_strip member.
mgiuca Feb 29, 2024
2defed9
Linkify concepts.
mgiuca Mar 4, 2024
945db03
Format processing steps.
mgiuca Mar 6, 2024
ea83f9f
Fix up links and add notes to be fixed up.
mgiuca Mar 6, 2024
bbc0ba4
Fix construction of URL pattern. Adds a TODO with more questions.
mgiuca Mar 7, 2024
300186d
Use manifest URL instead of scope URL as the base for processing scop…
mgiuca Mar 7, 2024
7c7f607
Linkify list.
mgiuca Mar 7, 2024
21dcb4b
Add link to manifest PR to linkify manifest and start URL.
mgiuca Mar 7, 2024
993081d
Clean up warnings.
mgiuca Mar 7, 2024
ec36601
Added a TODO about url.
mgiuca Mar 8, 2024
8929fd3
Respond to review.
mgiuca Mar 15, 2024
45b5701
Moved processing sections into subsections.
mgiuca Mar 15, 2024
10cc456
Major rewrite of tab_strip section.
mgiuca Mar 15, 2024
bfeefce
Better define home tab context and home tab scope.
mgiuca Mar 18, 2024
8857bca
scope_patterns: Scope pattern can now be either a full dict or a string.
mgiuca Mar 18, 2024
75550a6
Define has a home tab, for more clarity.
mgiuca Mar 18, 2024
80ef095
Minor refactor.
mgiuca Mar 18, 2024
dffed05
Move the check of the new tab button being outside of home tab scope …
mgiuca Mar 20, 2024
bb737f6
Added a note about History API.
mgiuca Mar 21, 2024
268d2cf
Use 'has a home tab'.
mgiuca Mar 21, 2024
3df45bc
Added usage example.
mgiuca Mar 21, 2024
40b89bc
Fix link to processed manifest.
mgiuca Mar 21, 2024
176b754
Use build a URL pattern instead of hand-creating a dictionary.
mgiuca Mar 25, 2024
d902a23
Invoke process the tab_strip member.
mgiuca Mar 25, 2024
2bf8cae
Properly define new_tab_button/url.
mgiuca Mar 25, 2024
6e32716
Remove issue about missing exports - now resolved.
mgiuca Apr 19, 2024
d43edf1
Added link to at-risk issue 97 (parsing scope patterns as a string).
mgiuca Apr 19, 2024
365d460
Refactor definition of home tab scope.
mgiuca Apr 22, 2024
374724d
exclude URLs outside of manifest scope from being in home scope.
mgiuca Apr 22, 2024
fd98052
Remove the official definition of home tab scope, as it is only used …
mgiuca Apr 22, 2024
21d19e7
Update usage example.
mgiuca Apr 22, 2024
3a3ba05
Rewrote invariants concerning home tab scope.
mgiuca Apr 22, 2024
957cb9e
Fix the logic of whether the app has a new tab button.
mgiuca Apr 24, 2024
afd09db
Respond to loubrett review.
mgiuca Apr 24, 2024
e41c10c
Some basic response to dmurph review.
mgiuca Apr 24, 2024
8098054
Rewrote confusing advice for developers.
mgiuca Apr 26, 2024
c9037cb
Rewrite navigations concerning the home tab scope.
mgiuca Apr 26, 2024
121f18e
Link to a GitHub issue instead of describing the issue inline.
mgiuca Apr 26, 2024
57014a6
Following dmurph's advise to standardize the variable names in proces…
mgiuca Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading