Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local HTTPS #36

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Local HTTPS #36

merged 1 commit into from
Jan 22, 2024

Conversation

backkem
Copy link
Collaborator

@backkem backkem commented Jan 20, 2024 •
edited by pr-preview bot
Loading

This PR is an initial take at addressing #34.

I do feel this fleshes out the functionality of the spec nicely by addressing the NAS/Home Assistant/Homeserver use-case.

Preview | Diff

anssiko
anssiko approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm fine with us taking a stab at this now.

I added some comments in #34 because I think they made more sense there.

Typo: s/it can use the it/it can use it

@backkem backkem merged commit 20b82b3 into WICG:main Jan 22, 2024
2 checks passed
@backkem backkem deleted the local-https branch January 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anssiko anssiko anssiko approved these changes

@ibelem ibelem Awaiting requested review from ibelem

@wangw-1991 wangw-1991 Awaiting requested review from wangw-1991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@backkem @anssiko