Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that document is fully active for window.fence methods #209

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

blu25
Copy link
Collaborator

@blu25 blu25 commented Jan 28, 2025

This PR makes the following changes

  • Add fully active document checks in window.fence methods as they appear in the associated implementation.
  • Move the {{SecurityError}} check in disableUntrustedNetwork() to the newly added active document check.
  • Have all instances of throw link to the throw definition.

Preview | Diff

@blu25 blu25 marked this pull request as ready for review January 28, 2025 16:56
@blu25 blu25 requested a review from VergeA January 28, 2025 16:56
Copy link
Collaborator

@VergeA VergeA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks good.

spec.bs Outdated Show resolved Hide resolved
@blu25 blu25 requested a review from VergeA January 28, 2025 20:32
@blu25 blu25 requested a review from domfarolino January 28, 2025 21:05
spec.bs Outdated Show resolved Hide resolved
@blu25 blu25 merged commit ef7eb0c into master Feb 4, 2025
2 checks passed
@blu25 blu25 deleted the liam-null-context branch February 4, 2025 19:18
github-actions bot added a commit that referenced this pull request Feb 4, 2025
SHA: ef7eb0c
Reason: push, by blu25

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants