[Spec] Network revocation patches for WebSocket and WebTransport APIs #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VergeA
reviewed
Jan 14, 2025
VergeA
reviewed
Jan 14, 2025
|
LGTM % 1 comment |
domfarolino
reviewed
Jan 18, 2025
| @@ -2123,6 +2135,16 @@ Issue: This will require a RFC to add a test-only function to the WPT web driver | |||
| 1. [=set/Append=] |nonce| to the user agent's [=network revocation nonce set=]. | |||
|
|
|||
| 1. [=fetch group/terminated|Terminate=] |settings|'s [=fetch/fetch group=]. | |||
|
|
|||
| 1. [=list/For each=] {{WebSocket}} object |webSocket| whose [=relevant settings object=] is | |||
There was a problem hiding this comment.
This algorithm is called in parallel so I don't really think it's valid for us to be inspecting "each" WebIDL WebSocket object of a given settings object, and running algorithms on it that (a) HTML currently runs as a task on the Document's event loop, and (b) the WebSocket spec itself only runs as proper event-loop-bound networking tasks. So we should probably (a) figure out a better way to restructure this, and (b) add a step at the beginning of this algorithm to assert that this is running in parallel, to make it easier to catch this kind of stuff in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the following things happen for both
WebTransportandWebSocketobjects:Preview | Diff