Add spec for APIs gated on network revocation. #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After untrusted network access has been disabled in a fenced frame via disableUntrustedNetwork(), script running in the frame will gain access to new powerful APIs. This patch provides an algorithm that other specs can use when implementing methods that should only succeed in a fenced frame with network access revoked. Currently, the only method that will rely on this algorithm is SharedStorage.get(), which is implemented in the Shared Storage draft spec. I'm planning to update that spec separately after this PR merges.
blu25
reviewed
Jan 10, 2025
blu25
approved these changes
Jan 10, 2025
domfarolino
reviewed
Jan 14, 2025
| defined in the [[Shared-Storage]] draft specification. | ||
|
|
||
| <div algorithm> | ||
| To <dfn export>determine if a navigable has fully revoked network</dfn> given a [=navigable=] |
There was a problem hiding this comment.
Out of curiosity, since we're exporting this, is there a corresponding PR made in the Shared Storage spec yet?
There was a problem hiding this comment.
Nope, not yet. I started working on one a while ago, but there's been some refactors to the spec since then. I was waiting to rewrite it until this PR landed, so I could have a correctly-exported definition and my Shared Storage spec would build properly.
domfarolino
reviewed
Jan 14, 2025
domfarolino
approved these changes
Jan 14, 2025
github-actions bot
added a commit
that referenced
this pull request
Jan 14, 2025
SHA: 82a9f09 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After untrusted network access has been disabled in a fenced frame via disableUntrustedNetwork(), script running in the frame will gain access to new powerful APIs. This patch provides an algorithm that other specs can use when implementing methods that should only succeed in a fenced frame with network access revoked.
Currently, the only method that will rely on this algorithm is SharedStorage.get(), which is implemented in the Shared Storage draft spec. I'm planning to update that spec separately after this PR merges.
Preview | Diff