Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for undocumented names; remove a dangling exported function #59

Merged
merged 2 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@

- `gridplot` with `GLMakie` and `PyPlot` now annotates the color bars with `boundary regions` and `cell regions`

- unit test for undocumented names

### Removed

- dangling exported function `backend!`

## [1.9.0] - 2024-11-25

### Added
Expand Down
5 changes: 5 additions & 0 deletions docs/src/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,8 @@ available_kwargs
vectorsample
quiverdata
```

## Creating movies
```@docs
movie
```
11 changes: 5 additions & 6 deletions docs/src/index.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
````@eval
using Markdown
Markdown.parse("""
$(read("../../README.md",String))
""")
````
# GridVisualize.jl

```@docs
GridVisualize
```
7 changes: 6 additions & 1 deletion src/GridVisualize.jl
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
"""
GridVisualize

$(read(joinpath(@__DIR__, "..", "README.md"), String))
"""
module GridVisualize

using Printf
Expand Down Expand Up @@ -31,7 +36,7 @@ export gridplot, gridplot!
export vectorplot, vectorplot!
export streamplot, streamplot!
export customplot, customplot!
export save, reveal, backend!
export save, reveal
export isplots, isvtkview, ispyplot, ismakie, isplutovista
export GridVisualizer, SubVisualizer
export plottertype, available_kwargs
Expand Down
6 changes: 6 additions & 0 deletions src/makie.jl
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ function save(fname, scene, XMakie, ::Type{MakieType})
return isnothing(scene) ? nothing : XMakie.save(fname, scene)
end


"""
movie( func, vis::GridVisualizer, ::Type{MakieType}; file = nothing, format = "gif", kwargs... )

Record a movie with GLMakie backend. MP4 files and gifs can be created.
"""
function movie(
func,
vis::GridVisualizer,
Expand Down
5 changes: 5 additions & 0 deletions src/plots.jl
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ function save(fname, scene, Plots, ::Type{PlotsType})
return isnothing(scene) ? nothing : Plots.savefig(scene, fname)
end

"""
movie( func, vis::GridVisualizer, ::Type{PlotsType}; file = nothing, format = "gif", kwargs... )

Record a movie with Plots backend. MP4 files and gifs can be created.
"""
function movie(
func,
vis::GridVisualizer,
Expand Down
7 changes: 7 additions & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,10 @@ include("../docs/makeplots.jl")
@testset "makeplots - CairoMakie" begin
makeplots(mktempdir(); Plotter = CairoMakie, extension = ".svg")
end


if isdefined(Docs, :undocumented_names) # >=1.11
@testset "UndocumentedNames" begin
@test isempty(Docs.undocumented_names(GridVisualize))
end
end
Loading