Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAC-451 fix : 정산 배치 로직 수정 #320

Merged
merged 2 commits into from
Oct 28, 2024
Merged

RAC-451 fix : 정산 배치 로직 수정 #320

merged 2 commits into from
Oct 28, 2024

Conversation

ywj9811
Copy link
Member

@ywj9811 ywj9811 commented Oct 28, 2024

🦝 PR 요약

정산 배치 로직 수정

✨ PR 상세 내용

만약, 성공하지 못할 경우 최대 5회 재시도 및 5회 실패시 슬랙 웹훅 발송

    private void checkSalaryJobSuccess(JobParameters jobParameters) throws JobExecutionAlreadyRunningException, JobRestartException, JobInstanceAlreadyCompleteException, JobParametersInvalidException {
        int retries = 0;
        boolean success = false;
        int seniorSize = seniorGetService.allSeniorId()
                .size();
        while (retries < MAX_RETRIES){
            int salarySize = salaryGetService.findAllNext()
                    .size();
            if (salarySize == seniorSize) {
                success = true;
                break;
            }
            jobLauncher.run(salaryJobWithAdmin, jobParameters);
        }
        if (!success) {
            slackErrorMessage.sendSlackSalaryError();
        }
    }

🚨 주의 사항

주의할 부분이 무엇인가요? - 지우고 작성

✅ 체크 리스트

  • 리뷰어 설정했나요?
  • Label 설정했나요?
  • 제목 양식 맞췄나요? (ex. RAC-1 feat: 기능 추가)
  • 변경 사항에 대한 테스트 진행했나요?

@ywj9811 ywj9811 added 🐞 BugFix 오류 수정 ✨ Feature 새로운 기능 추가 labels Oct 28, 2024
@ywj9811 ywj9811 self-assigned this Oct 28, 2024
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ywj9811 ywj9811 merged commit 7bd4487 into develop Oct 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 BugFix 오류 수정 ✨ Feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant