refactor: [sparse_weights] get for predict #4651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
reviewed
Oct 13, 2023
jackgerrits
reviewed
Oct 13, 2023
rajan-chari
reviewed
Oct 16, 2023
zwd-ms
approved these changes
Oct 16, 2023
lalo
reviewed
Oct 16, 2023
| @@ -6021,7 +6021,7 @@ | |||
| { | |||
| "id": 465, | |||
| "desc": "cb_explore_adf with epsilon-greedy exploration using --sparse_weights and saving model", | |||
| "vw_command": "--cb_explore_adf --epsilon 0.1 -d train-sets/cb_test.ldf --noconstant --sparse_weights -f standard_sparse_model.vw", | |||
| "vw_command": "--cb_explore_adf --epsilon 0.1 -d train-sets/cb_test.ldf --noconstant --sparse_weights -f standard_sparse_model.vw -q::", | |||
There was a problem hiding this comment.
there's a total of 3 tests using --sparse_weights, might be the opportunity to beef it up - maybe unit tests?
There was a problem hiding this comment.
apart from that, would be cool to add some sparse benchmarks to master and see if they are affected by this change
There was a problem hiding this comment.
benchmarks added, tests can be added in a separate PR
bassmang
changed the title
|
The one change that makes this PR side effect free is specialization of get for random init. In that case, insert something in the map. |
|
Based on latency tests done so far, this is definitely desirable. |
olgavrou
reviewed
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.