Test PR with non-corrupt STLs #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FHeilmann
changed the title
BREAKING CHANGE: This breaks compatibility with all previous versions due to a renaming of most functions
|
Hi, thank you for submitting your PR. Added/Changed mods detected in this PR:
Tool check results overview:
Tool check results details:SUCCESS: ✅File checker
Mod structure checker
STL corruption checker
STL rotation checker
WARNING:
|
| Item | Result | Reason |
|---|---|---|
| 1-0-R/handle/STL/handle_outer_part.stl | This file is larger than 2 MB! | |
| 1-0-R/handle/STL/handle_inner_part.stl | This file is larger than 2 MB! | |
| 1-0-R/handle/CAD/handle.step | This file is larger than 2 MB! | |
| 1-0-R/handle/CAD/handle.FCStd | This file is larger than 2 MB! | |
| 120decibell/exhaust_housing_side_entry/STL/[a]_exhaust_housing_insert_thread.stl | This file is larger than 2 MB! | |
| 120decibell/exhaust_housing_side_entry/STL/[a]_filter_access_cover.stl | This file is larger than 2 MB! | |
| 120decibell/exhaust_housing_side_entry/STL/exhaust_filter_housing.stl | This file is larger than 2 MB! | |
| 120decibell/exhaust_housing_side_entry/CAD/exhaust_housing_side_entry.f3d | This file is larger than 2 MB! |
STL corruption checker
| Item | Result | Number of STL fixes applicable |
|---|---|---|
| [a]_exhaust_housing_insert_plug.stl | STL is not a binary STL. Consider converting it to save space! | |
| [a]_exhaust_housing_insert_thread.stl | STL is not a binary STL. Consider converting it to save space! | |
| [a]_filter_access_cover.stl | STL is not a binary STL. Consider converting it to save space! | |
| exhaust_filter_housing.stl | STL is not a binary STL. Consider converting it to save space! |
STL rotation checker
| Item | Result | Original orientation | Suggested orientation |
|---|---|---|---|
| main_body_daylight_B.stl |  |
 |
|
| main_body_daylight_A.stl |  |
 |
|
| cable_tie_DIN_mount.stl |  |
 |
|
| bottom_mount_clip_x4.stl |  |
 |
|
| main_body_rainbow_B.stl |  |
 |
|
| [a]_exhaust_housing_insert_plug.stl |  |
 |
|
| exhaust_filter_housing.stl |  |
 |
I am a 🤖, this comment was generated automatically!
Made with ❤️ by the VoronDesign GitHub Team
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Voron-GitHub-Bot
approved these changes
Jan 6, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Voron-GitHub-Bot
dismissed
their stale review
Dismissing review due to updates!
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.