Tbcct 94 be excel importer 1 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexeh
force-pushed
the
TBCCT-94-BE-Excel-importer-1
branch
from
9e52fb0 to
a5f35df
Compare
alexeh
force-pushed
the
TBCCT-94-BE-Excel-importer-1
branch
from
35ed5c7 to
7c84586
Compare
alexeh
force-pushed
the
TBCCT-94-BE-Excel-importer-1
branch
from
557962f to
8e61771
Compare
catalin-oancea
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve the import functionality, update dependencies, and enhance logging. The most important changes include updating the database image in workflow files, enhancing the
AppModuleto import country data, and refactoring the import service and related components.Workflow Updates:
.github/workflows/api-tests.ymland.github/workflows/e2e-tests.yml: Updated the database image frompostgres:13topostgis/postgis:16-3.4. [1] [2]AppModule Enhancements:
api/src/app.module.ts: Enhanced theAppModuleto implementOnModuleInitfor importing country data from an SQL file during module initialization. [1] [2] [3]Import Service Refactoring:
api/src/modules/import/import.service.ts: Refactored the import service to use a newExcelParserInterfaceand added logging for import operations.api/src/modules/import/excel-base-data.dto.ts: Added a new typeBaseDataJsonto define the structure of base data JSON.api/src/modules/import/services/entity.preprocessor.ts: Refactored theEntityPreprocessorto process base data JSON and convert it to database entities.api/src/modules/import/services/excel-parser.interface.ts: Updated theExcelParserInterfaceto parse only themaster_tablesheet.api/src/modules/import/services/xlsx.parser.ts: Modified theXlsxParserto return parsed base data JSON instead of a generic object.Import Controller and Module Updates:
api/src/modules/import/import.controller.ts: Updated the import controller to useTsRestHandlerand refactored the file upload endpoint.api/src/modules/import/import.module.ts: Updated the import module to provide theExcelParserTokenusing theXlsxParserclass.