fix(api): Change Project Maximum total abatement cost and total cost … #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in order to align it with the latst busines slogic
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
ProjectsServiceand related tests to modify the way maximum values are calculated and to update test cases accordingly. The most important changes are as follows:Changes to Maximum Value Calculations:
api/src/modules/projects/projects.service.ts: Changed the calculation of maximum values forabatement_potentialandtotal_costfrom usingSUMtoMAX.Updates to Test Cases:
api/test/integration/projects/projects.spec.ts: Updated imports to includeCOST_TYPE_SELECTORfromprojects.entity.api/test/integration/projects/projects.spec.ts: Modified test project creation to usecapexNPVandopexNPVinstead oftotalCostandtotalCostNPV.api/test/integration/projects/projects.spec.ts: AddedcostRangeSelectorparameter to query in tests and updated expected maximum values.