Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added --exts argument in order to specify which file extension(s) should be scanned #1314

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

emmanubo
Copy link

@emmanubo emmanubo commented Jul 1, 2020

added --exts argument in order to specify which file extension(s) should be scanned.
This change is fully implemented in yara.c.
Usage example :

 yara64.exe -C webshells.bin c:\inetpub\wwwroot  --exts=.asp/.aspx/.jsp/.php

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@emmanubo
Copy link
Author

emmanubo commented Jul 6, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot I fixed it.

@emmanubo
Copy link
Author

emmanubo commented Jul 6, 2020

@googlebot I fixed it.

@DanielRuf
Copy link

DanielRuf commented Jun 28, 2022

Can you remove the .vs and windows files / folders from this PR?

@DanielRuf
Copy link

Why is the separator for the option list / instead of ,?

See also the current CLI options and how they are used, for example multiple -t options to create an array.

@emmanubo
Copy link
Author

Hello Daniel, I cleaned up unneeded files in the PR (I couldn't delete the sqllite file but it's not required). Regarding the use of "/" as a separator, let's say it's a personal choice but using "," is fine too. I hope this feature will be implemented. I understand that you need the opposite feature (to select files not having a specific ext), I think it would be nice to have it too.

@DanielRuf
Copy link

Hello Daniel, I cleaned up unneeded files in the PR (I couldn't delete the sqllite file but it's not required).

Thank you very much. Looks much better now.

Regarding the use of "/" as a separator, let's say it's a personal choice but using "," is fine too

I think this is the least problem since the final implementation can still change, as long as it works.

I hope this feature will be implemented.

I hope so too.

I understand that you need the opposite feature (to select files not having a specific ext), I think it would be nice to have it too.

Exactly. I need the opposite (exclude specific file extensions from the scan).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants