remove JS and CSS docs as they proved difficult to maintain (#2194)

* remove JS and CSS docs as they proved difficult to maintain * fix CI * use concurrent-ruby for 6.1 support * use concurrent-ruby that works * force 1.3.4 * Update docs/CHANGELOG.md * Update docs/CHANGELOG.md
ViewComponent · Jan 16, 2025 · e94c1ed · e94c1ed
1 parent eba4c14
commit e94c1ed
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 172 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -3,7 +3,7 @@ PATH
   specs:
     view_component (3.21.0)
       activesupport (>= 5.2.0, < 8.1)
-      concurrent-ruby (~> 1.0)
+      concurrent-ruby (= 1.3.4)
       method_source (~> 1.0)
 
 GEM

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -10,6 +10,10 @@ nav_order: 5
 
 ## main
 
+* Remove JS and CSS docs as they proved difficult to maintain and lacked consensus.
+
+    *Joel Hawksley*
+
 * Do not prefix release tags with `v`, per recommendation from @bkuhlmann.
 
     *Joel Hawksley*

diff --git a/docs/guide/javascript_and_css.md b/docs/guide/javascript_and_css.md
diff --git a/test/sandbox/test/rendering_test.rb b/test/sandbox/test/rendering_test.rb
@@ -16,8 +16,8 @@ def test_render_inline_allocations
     MyComponent.ensure_compiled
 
     allocations = (Rails.version.to_f >= 8.0) ?
-      {"3.5.0" => 117, "3.4.1" => 117, "3.3.6" => 129} :
-      {"3.3.6" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}
+      {"3.5.0" => 117, "3.4.1" => 117, "3.3.7" => 129} :
+      {"3.3.7" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}
 
     assert_allocations(**allocations) do
       render_inline(MyComponent.new)

diff --git a/view_component.gemspec b/view_component.gemspec
@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "activesupport", [">= 5.2.0", "< 8.1"]
   spec.add_runtime_dependency "method_source", "~> 1.0"
-  spec.add_runtime_dependency "concurrent-ruby", "~> 1.0"
+  spec.add_runtime_dependency "concurrent-ruby", "1.3.4" # lock version that supports Rails 6.1
   spec.add_development_dependency "allocation_stats", "~> 0.1.5"
   spec.add_development_dependency "appraisal", "~> 2.4"
   spec.add_development_dependency "benchmark-ips", "~> 2.13.0"