Chore / Upgrade codeceptjs from 3.5.5 to 3.6.4 #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
langemike
changed the title
|
@ChristiaanScheermeijer I know you explained it to me, still i find it difficult to grasp 😅 |
|
I performed the e2e tests 3 times in github. This is the third: https://github.com/Videodock/ott-web-app/actions/workflows/web-test-e2e.yml If this succeed, I consider this PR ready for review and i will submit it to the public (OSS) repo. |
langemike
added
the
pr-submitted
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
langemike
force-pushed
the
chore/codeceptjs-upgrade
branch
from
1c97c4b
to
47e7df5
Compare
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few issues when upgrading
codeceptjsandplaywrightto their latest versions.Due to a recent change in seeAttributesOnElements, it cannot handle empty values, so I switched to
grabAttributeFromPrimarily this failure hunted me almost the whole afternoon:
I finally came to the conclusion the
cancelPlanflow is flaky. I still cannot pinpoint the exact cause, but I know the issue doesn't occur in GitHub. It didn't happen initially on codecept 3.5.5, but now when run it again (locally) on this version, I can reproduce it. So this definitely got my off-guard. This is something we need to fix eventually. Not for now.Ticket: https://videodock.atlassian.net/browse/MAINT-456