-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor / form fields and control elements #183
Refactor / form fields and control elements #183
Conversation
@ChristiaanScheermeijer, can you also take another look at this PR (specifically to the description, maybe we need to explain more about the refactor?) |
@MelissaDTH I think we can submit this to the open source repo 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, Chris!
035b008
to
3f23ea7
Compare
04323b6
to
8df8c30
Compare
f768202
to
3d2fa46
Compare
Is merged in |
Description
Input
,Select
,FormField
andCheckbox
componentsFromField
component*
to a field if it is required and ensuresaria-hidden="true"
is appliedThis PR is based on this previously approved #105 PR
Steps completed:
According to our definition of done, I have completed the following steps: