Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / form fields and control elements #183

Closed

Conversation

ChristiaanScheermeijer
Copy link
Member

@ChristiaanScheermeijer ChristiaanScheermeijer commented Apr 17, 2024

Description

  • This PR introduces new Input, Select, FormField and Checkbox components
  • Unifies form field labels, aria attributes and helper text in the FromField component
  • Removes the “(Optional)“ marking from custom components for fields that are not required
  • Adds an asterisks * to a field if it is required and ensures aria-hidden="true" is applied
    • The e2e test 'The Sign up modal will invalidate upon submit only if a value is inputted' is removed due to the fact that it is corrected in this PR: GitHub test file
  • Solves: OTT-1261

This PR is based on this previously approved #105 PR

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@ChristiaanScheermeijer ChristiaanScheermeijer added the working-branch This is a working branch for a collection of tasks label Apr 17, 2024
@MelissaDTH MelissaDTH temporarily deployed to Deployment Previews April 18, 2024 13:37 — with GitHub Actions Inactive
@MelissaDTH
Copy link

@ChristiaanScheermeijer, can you also take another look at this PR (specifically to the description, maybe we need to explain more about the refactor?)

@ChristiaanScheermeijer ChristiaanScheermeijer added pending-pr and removed working-branch This is a working branch for a collection of tasks labels Apr 22, 2024
@ChristiaanScheermeijer
Copy link
Member Author

@MelissaDTH I think we can submit this to the open source repo 🎉

Copy link

@royschut royschut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦬

Copy link

@langemike langemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Chris!

@MelissaDTH MelissaDTH force-pushed the feat/refactor-inputs-and-form-controls branch from f768202 to 3d2fa46 Compare April 23, 2024 15:05
@MelissaDTH MelissaDTH temporarily deployed to Deployment Previews April 23, 2024 15:06 — with GitHub Actions Inactive
@MelissaDTH MelissaDTH added the pr-submitted The PR has been submitted to the OTT Web App repo label Apr 23, 2024
@MelissaDTH
Copy link

Is merged in jw-ott-web-app repo, therefore closed

@MelissaDTH MelissaDTH closed this Apr 26, 2024
@royschut royschut deleted the feat/refactor-inputs-and-form-controls branch April 26, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-submitted The PR has been submitted to the OTT Web App repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants